package-hw: remove kfocus-main dependency, kfocus-common is what is needed and is already a pre-depends. - #30
Open
eeickmeyer wants to merge 2 commits into
Open
package-hw: remove kfocus-main dependency, kfocus-common is what is needed and is already a pre-depends.#30eeickmeyer wants to merge 2 commits into
eeickmeyer wants to merge 2 commits into
Conversation
eeickmeyer
changed the title
eeickmeyer
changed the title
eeickmeyer
force-pushed
the
RR-2026-Q3
branch
2 times, most recently
from
August 10, 2026 00:00
769b118 to
eb47425
Compare
…package management
eeickmeyer
changed the title
Contributor
Author
|
Ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a redo of #29 but with a better solution.
Justification: This has an unwanted side-effect for Ubuntu Studio users in that, if someone installs kfocus-hw on an Ubuntu Studio installation, it will, via dependency resolution, remove ubuntustudio-desktop, ubuntustudio-default-settings, and other packages, essentially converting it into a Kubuntu desktop.
Additionally, if one were to want hardware support on an Edubuntu system (for instance), it would install all of Kubuntu, including KDE Plasma. For a GNOME system, this would be undesirable.
This is of particular importance for fan control as kfocus-power-fan requires kfocus-hw requires kfocus-settings requires kubuntu-settings requires kubuntu-desktop. kfocus-hw is required for the profile db.
Uupon investigation, I found that it's best, in this case, to demote
kfocus-mainin thekfocus-hwpackage from Depends to Recommends. askfocus-hwis already a dependency ofkfocus-main, this solves the problem and makes it so that, in order to install on non-Kubuntu flavors, that all one has to do issudo apt install --no-install-recommends kfocus-keyboard kfocus-hw kfocus-power-fanand Kubuntu, nor the other Kfocus items, will be installed. This enables an hardware-only support method.However, @mmikowski pointed out that it is far more accurate to change the depends to
kfocus-commonsince the sourcing of thecommon2.sourcefile is what is actually needed here. With that in mind, this now changes the dependency in question fromkfocus-maintokfocus-common, but sincekfocus-commonis already a Pre-Depends, this removes thekfocus-maindependency line entirely as changing it is redundant. This relieves the need to use--no-install-recommendsmeaning the single hardware support command for non-Kubuntu systems becomessudo apt install kfocus-keyboard kfocus-hw kfocus-power-fan.We had talked in the past about an Ubuntu Studio partnership, and this issue is a barrier; not on a relationship level, but on a functionality level. If this PR is accepted, that makes it easier to move forward.