Conversation
The repo is public and nothing ran the tests. Two of them hold product promises rather than implementation details — synthesize() must call nothing but the caller's distill, and record() must block by default — and both would break silently under a well-meaning refactor. Matrix is 3.9 and 3.13: the floor in requires-python and current. A client library breaking on the Python a user already has is something you otherwise learn from an issue. The job also runs `build` + `twine check`, because today's release failed on Metadata-Version 2.5 with an error that named metadata and meant toolchain. That belongs in CI, not in the moment someone is trying to ship.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repo is public and nothing ran the tests.
Two of them hold product promises rather than implementation details:
synthesize()must call nothing but the caller'sdistill— the whole claim of the BYOM pathrecord()must block by default — the alternative is a race that reads as flaky memoryBoth would break silently under a well-meaning refactor. Now they gate the merge.
Matrix is 3.9 and 3.13 — the floor in
requires-pythonand current. A client library breaking on the Python a user already has is something you otherwise learn from an issue.The job also runs
build+twine check, because today's release failed onMetadata-Version: 2.5with an error that named metadata and meant toolchain. That check belongs in CI, not in the moment someone is trying to ship.