chore(release): 0.4.0 - #14
Merged
Merged
Conversation
record() grew two keywords since 0.3.0 — occurred_at, and flush() alongside background=True. Both landed under a 0.3.1 patch number: the second branch was cut from main before the first merged, so its version bump looked for a string that was not there yet and did nothing. Silent, and only visible when the built artifact said 0.3.1. A patch number is the wrong shelf for a signature that grew. This is the release someone would pin to get either feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
record()grew two keywords since 0.3.0 —occurred_at, andflush()alongsidebackground=True— butmainis sitting at 0.3.1.Both landed under that patch number because the second branch (#13) was cut from
mainbefore the first (#12) merged. Its version bump looked for0.3.1, which did not exist on that branch yet, and did nothing. Silent — only visible when the built artifact came out labelled 0.3.1.A patch number is the wrong shelf for a signature that grew.
Verified on merged main before releasing: all five suites pass (25 assertions), and
flush()+occurred_atcompose — a background record carrying a timestamp is still in flight whenflush()is called, and lands with the timestamp intact. No existing test covered the two together, since they arrived in separate branches.