cloudsmith_release: make ruby_version configurable, bump default to JRuby 10 + bundler 2.7.2 - #91
Open
tungleduyxyz wants to merge 1 commit into
Open
tungleduyxyz wants to merge 1 commit into
tungleduyxyz wants to merge 1 commit into
Conversation
…Ruby 10 + bundler 2.7.2 Add a ruby_version input (defaulting to jruby-10.0.6.0, the JRuby 10 LTS line) so callers can override the JRuby version used when with_ruby is true, instead of it being hardcoded to jruby-9.4.15.0. Bump the paired bundler install to 2.7.2 to match JRuby 10.0.x's bundled bundler version. Used by killbill-admin-ui-standalone's snapshot_release.yml, which already pins jdk: '21' explicitly for its own JDK setup step (unaffected by this repo's jdk input default). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to killbill-admin-ui-standalone's JRuby 10 upgrade, which uses this shared
cloudsmith_release.ymlworkflow (viasnapshot_release.yml,with_ruby: 'true') to build/release its WAR.ruby_versioninput (defaulting tojruby-10.0.6.0, the JRuby 10 LTS line) so callers can override the JRuby version used whenwith_rubyis true, instead of it being hardcoded tojruby-9.4.15.0.gem install bundlerstep to2.7.2to match JRuby 10.0.x's bundled bundler version.killbill-admin-ui-standalone's
snapshot_release.ymlalready pinsjdk: '21'explicitly for its own JDK setup step, so this change is independent of (and doesn't conflict with) the separate in-progressjava21branch that changes this workflow'sjdkinput default.Re-applies #88 (reverted by #89).
Note
No functional change for any other caller of this reusable workflow: the new
ruby_versioninput defaults to the JRuby 10 LTS version, but existing callers that don't setwith_ruby: 'true'are unaffected, and any caller relying on the exact old default can pinruby_version: 'jruby-9.4.15.0'explicitly if needed.