Skip to content

chore: land green Dependabot bumps with Jackson alignment - #14

Closed
JeffTax wants to merge 1 commit into
killbill:mainfrom
JeffTax:chore/no-ref/fix-dependabot-deps
Closed

JeffTax wants to merge 1 commit into
killbill:mainfrom
JeffTax:chore/no-ref/fix-dependabot-deps

Conversation

@JeffTax

@JeffTax JeffTax commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Lands the already-green Dependabot upgrades in one PR: actions/checkout v7, actions/setup-java v6, codeql-action v4, maven-surefire-plugin 3.6.0, wiremock-standalone 3.0.1, Jackson 2.22.x.
  • Fixes the failing Jackson databind bump (build(deps): bump com.fasterxml.jackson.core:jackson-databind from 2.18.6 to 2.22.2 #3): bumping only jackson-databind to 2.22.2 leaves parent-managed jackson-annotations at 2.13.x, which lacks JsonSerializeAs and breaks tests. This PR aligns jackson-annotations (2.22), jackson-core, and jackson-databind together.
  • Does not bump killbill-oss-parent to 0.147.x (Bump org.kill-bill.billing:killbill-oss-parent from 0.146.87 to 0.147.21 #7). That parent drops managed versions for javax.inject / org.jooby:jooby and is part of the Jakarta / JDK 21 migration across Kill Bill — needs a dedicated migration PR, not Dependabot.

Supersedes

Not included

Tests

  • JAVA_HOME=…/openjdk@11 mvn -B -ntp test — 54 tests, 0 failures.

Bump Jackson core/databind/annotations together so databind 2.22 does
not fail on parent's jackson-annotations 2.13, and apply the other
already-green Dependabot upgrades (wiremock, surefire, GHA actions).

Leave killbill-oss-parent at 0.146.x — 0.147 is a Jakarta/JDK 21
migration, not a drop-in Dependabot bump.
@JeffTax

JeffTax commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

@reshmabidikar — JeffTax only has pull access on this repo, so I can't merge/close the Dependabot PRs or push directly.

Could you:

  1. Review + merge this PR when CI is green
  2. Close Dependabot build(deps): bump com.fasterxml.jackson.core:jackson-databind from 2.18.6 to 2.22.2 #3build(deps): bump com.fasterxml.jackson.core:jackson-core from 2.18.6 to 2.22.2 #6 and build(deps-dev): bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.5 to 3.6.0 #8build(deps): bump github/codeql-action from 3 to 4 #10 as superseded
  3. Close Bump org.kill-bill.billing:killbill-oss-parent from 0.146.87 to 0.147.21 #7 (oss-parent 0.147) as not a drop-in bump — needs a Jakarta/JDK 21 migration
  4. Optionally add JeffTax as a collaborator with write so we can land follow-ups without pinging you

Local verification: JDK 11, `mvn -B -ntp test` — 54/54 green.

@JeffTax

JeffTax commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Superseded — Dependabot fixes landed on #13 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant