Skip to content

update readme to with auto hmac generation - #17

Merged
reshmabidikar merged 2 commits into
killbill:mainfrom
nitanshukintsugi:fix/update_readme_accomodating_auto_hmac_generation
Sep 24, 2026
Merged

reshmabidikar merged 2 commits into
killbill:mainfrom
nitanshukintsugi:fix/update_readme_accomodating_auto_hmac_generation

Conversation

@nitanshukintsugi

@nitanshukintsugi nitanshukintsugi commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Document that Enable Tax Collection in Kintsugi generates the HMAC and uploads uploadPluginConfig (no manual secret paste in the product flow).
  • Keep manual curl upload as a local/fallback path.
  • Clarify healthcheck returns {"message":"Kintsugi plugin configured"} only — use GET .../uploadPluginConfig/killbill-kintsugi to inspect config.
  • Align docker/README.md and docs draft notes with the same flow.

Test plan

  • Read through README setup + verify sections for accuracy
  • Confirm healthcheck vs GET plugin config distinction is clear for operators

@reshmabidikar reshmabidikar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a minor comment.

Comment thread docs/killbill-docs-pr.md Outdated
Address review: tenant config is provisioned only via Enable Tax
Collection; keep GET inspect and docker toolkit for maintainers.

Co-authored-by: Cursor <cursoragent@cursor.com>
@reshmabidikar
reshmabidikar merged commit e64ce96 into killbill:main Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants