Fix typos in comments and docstrings, and GIN script default model - #1
Open
Avicennasis wants to merge 1 commit into
Open
Fix typos in comments and docstrings, and GIN script default model#1Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 8 typos in comments and docstrings, plus one copy-paste artifact in
run_pgd_gin.py's argument defaults.src/models/layers.py
# Inspired and Adapted and inspired from ...-># Inspired and Adapted from ...(duplicated "and inspired"; now matches the wording already used at the top ofsrc/models/utils.py)run_pgd.py
# Set to seed-># Set seedrun_pgd_gin.py
# Let's init the GCN-># Let's init the GIN(the line below it constructsGIN(...); the comment was carried over fromrun_pgd.py)parser.add_argument('--model', ..., default='GCN')->default='GIN'. This is the GIN driver script, so'GCN'is a copy-paste leftover fromrun_pgd.py. It is a no-op at runtime today becauseargs.modelis never read in either script (the model class is hard-coded), but the default is shown in--helpand would be wrong if the flag is ever wired up. Happy to drop this hunk if you would rather keep the change comment-only.src/models/utils.py
- Takes the number fold->- Takes the fold number(bothtrain_functionandtest_functiondocstrings - fixing only one would have left the two docstrings inconsistent)transform the adjacency matrices as block matrix->into a block matrix(both docstrings; the code callssp.block_diag(adj_batch), producing a single block-diagonal matrix per batch)it transform the->it transforms theSum of predictions with agree with labels->predictions which agree with labelsNo behavioural changes: everything except the
default='GIN'line is a comment or docstring. Copyright/licence headers were left untouched.