Skip to content

Fix catch-up checks across partial minutes - #50

Open
bensynapse wants to merge 1 commit into
kipe:mainfrom
bensynapse:fix-catch-up-minute-boundary
Open

bensynapse wants to merge 1 commit into
kipe:mainfrom
bensynapse:fix-catch-up-minute-boundary

Conversation

@bensynapse

Copy link
Copy Markdown

I run Live Tennis API.

has_been("1 * * * *", since, now) returns false for 12:00:59 through 12:01:01. Its minute steps retain the starting seconds and skip the final minute.

The scan now starts on the minute boundary after validating the original timestamps. Tests cover microseconds, hour and year boundaries, and the documented datetime libraries. Reversed intervals still raise, including when both timestamps fall in one minute.

The four boundary regressions fail on main. uv run coverage run -m unittest discover -b passes all 22 tests on Python 3.10 and 3.14. uv run coverage report --fail-under=100 reports 100% on both versions.

uv run flake8 pycron --max-line-length=88, uv run pylint pycron, uv run mypy pycron and uv build also pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant