Repository navigation
Fix catch-up checks across partial minutes - #50
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
has_been("1 * * * *", since, now)returns false for 12:00:59 through 12:01:01. Its minute steps retain the starting seconds and skip the final minute.The scan now starts on the minute boundary after validating the original timestamps. Tests cover microseconds, hour and year boundaries, and the documented datetime libraries. Reversed intervals still raise, including when both timestamps fall in one minute.
The four boundary regressions fail on main.
uv run coverage run -m unittest discover -bpasses all 22 tests on Python 3.10 and 3.14.uv run coverage report --fail-under=100reports 100% on both versions.uv run flake8 pycron --max-line-length=88,uv run pylint pycron,uv run mypy pycronanduv buildalso pass.