Add /order/{providerId} endpoint - #183
Merged
Merged
Conversation
The previous flow for placing an order:
1. Follow a link to /provider/{}
2. Click an item
3. Get told to log in
4. Close the popup, find the log-in button
5. Log in, get redirected to the home page
6. Remember what you wanted to order
7. Find the page of the provider
8. Find what you wanted to order
9. Don't order because the item went out of stock while you went on an adventure
After this change:
1. Follow a link to /order/{}
2. Log in
3. Find item
4. Order
Gerviba
reviewed
Sep 8, 2025
| ).permitAll() | ||
| auth.requestMatchers("/loggedin", "/login").permitAll() | ||
| auth.requestMatchers("/api/**").permitAll() | ||
| auth.requestMatchers("/order/**").hasRole(Role.USER.name) |
Member
There was a problem hiding this comment.
Since "/provider/**", is permit all, I'd use .permitAll() here as well.
Member
Author
There was a problem hiding this comment.
Forgot to write down how this works. Check the first paragraph of the PR's description
Member
There was a problem hiding this comment.
Ah, I see. Not sure if they get redirected back to that provider, otherview it's ok!
Member
Author
There was a problem hiding this comment.
For endpoints that require auth, if the user is not logged in, before redirecting to the login page, the framework stores the path and redirects the user back after logging in.
ASP.NET supports a redirectUri query parameter for the login endpoint, but I couldn't find an equivalent feature here, so I went with this workaround.
Gerviba
approved these changes
Sep 8, 2025
Isti01
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an endpoint that prompts the user to log in if not logged in, then redirects to the given provider's page.
The previous flow for placing an order:
/provider/{}After this change:
/order/{}