feat: add optional heading image to secondary nav - #903
Conversation
| return ['subheadline', 'title'].includes(value); | ||
| }, | ||
| }, | ||
| headingImage: { |
There was a problem hiding this comment.
where do we plan to store the images that might be used here?
There was a problem hiding this comment.
It's being used in Contentful (specifically the U.S. Landing pages). I have a corresponding PR ready in CPS, but wanted to get this out first
There was a problem hiding this comment.
Ok so we'll be referencing a contentful cdn url I guess...
| @@ -17,6 +18,7 @@ | |||
| }, | |||
| args: { | |||
There was a problem hiding this comment.
Can we add headingStyle to the story args, and possibly a new story showing the heading style.
| export default { | ||
| title: 'Page Frame/KvSecondaryNav', | ||
| component: KvSecondaryNav, | ||
| argTypes: { |
There was a problem hiding this comment.
Maybe headingStyle here as well with the 2 possible values
mcstover
left a comment
mcstover
left a comment
There was a problem hiding this comment.
Stories look good. I also think that the title will be better with the bolder type style so that would be a good improvement to add.
4 participants
Ticket: KUSPMTM-31
This PR adds the component variation to add an image in place of the header text for the secondary nav. Since the component itself has relied on rendering text for the header, it's set as an optional enhancement.