Skip to content

feat: removing lending routes as ported to cps combo page #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roger-in-kiva wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: removing lending routes as ported to cps combo page #6859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions src/router/routes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,26 +290,10 @@ export default [
path: '/lend-by-category/blackrock',
redirect: '/lend-by-category',
},
{
path: '/lend-by-category',
component: () => import('#src/pages/LoanFinding/LoanFinding'),

@mcstover mcstover Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both of these /lend-by-cat routes should become redirects. This one is easy, not sure exactly how the category specific endpoint below will translate to the new page.

meta: {
unbounceEmailCapture: true,
},
},
{
path: '/lend-by-category/recommended-by-lenders',
redirect: '/lend-by-category'
},
{
path: '/lend-by-category/:category',
component: () => import('#src/pages/Lend/LoanChannelCategoryPage'),
meta: {
excludeFromStaticSitemap: true,
unbounceEmailCapture: true,
unbouncePopUp: true,
},
},
{
path: '/lend-beta/:id',
redirect: '/lend/:id'
Expand Down Expand Up @@ -346,14 +330,6 @@ export default [
unbouncePopUp: true,
}
},
{
name: 'lend-filter',
path: '/lend/filter',
component: () => import('#src/pages/Lend/LoanSearchPage'),

@mcstover mcstover Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's possible to set this as a redirect and trigger a full page refresh, that would probably be good to set here. That way we'd be back out at the ingress and flux configs would handle pushing this to cps instead.

@roger-in-kiva roger-in-kiva Apr 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are currently having same route on cps, not sure what you mean.
From /lend/filter to /lend/filter?

My guess is adding these routes to cps flux and removing from ui flux, like this:
https://github.com/kiva/flux/compare/MP-2683_combo_page_routes_update?expand=1

Open if you have other option in mind.

@mcstover mcstover Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this one, I was just thinking about how to handle internal to ui links routing to lend/filter. We want to make sure it causes a full page navigation. Probably just removing it like you have here will do that though ;)

meta: {
unbounceEmailCapture: true,
},
},
{
name: 'filter-alpha',
path: '/lend/filter-alpha',
Expand Down
Loading