Skip to content

feat: [CIT-5223] bump @kiva/kv-shop to ^3.8.32 - #7267

Merged
JoeTravisKiva merged 1 commit into
mainfrom
CIT-5223
Sep 17, 2026
Merged

JoeTravisKiva merged 1 commit into
mainfrom
CIT-5223

Conversation

@JoeTravisKiva

@JoeTravisKiva JoeTravisKiva commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

CIT-5223 — the ui half. The kv-shop change is kiva/kv-ui-elements#905, merged and released as 3.8.32.

Why

Express checkout's credit controls (ExpressCheckoutTotals.vue → applyKivaCredit / removeKivaCredit) run through kv-shop's callShopMutation, not src/util/basketUtils.js — so CIT-5181 (#7266) does not reach them.

Before 3.8.32, parseShopError had no mapping for checkout_in_progress / shop.checkoutInProgress, so both hit its catch-all and returned "An unknown error occurred." with the original code rewritten to shop.unknown. That rewrite is why it could not be fixed from ui — there was nothing left to classify on.

What

One line in package.json, plus the lockfile. The lockfile diff touches only @kiva/kv-shop — no other package moved.

Verification

  • Confirmed the published 3.8.32 tarball actually contains the fix (both codes and the expected copy) before bumping, rather than assuming the release included it
  • Confirmed the installed build carries it after npm install
  • 341 test files / 5444 tests passing, lint clean (149 warnings, all pre-existing)

Notes

🤖 Generated with Claude Code

3.8.32 adds checkout_in_progress and shop.checkoutInProgress handling to
parseShopError. Without it, a lender applying or removing Kiva credit
during their own in-flight checkout sees "An unknown error occurred."
from express checkout, because those paths run through kv-shop's
callShopMutation rather than src/util/basketUtils.js.

Verified the published build carries the fix before bumping.

CIT-5223

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@JoeTravisKiva JoeTravisKiva changed the title CIT-5223: bump @kiva/kv-shop to ^3.8.32 feat: [CIT-5223] bump @kiva/kv-shop to ^3.8.32 Sep 17, 2026
@JoeTravisKiva
JoeTravisKiva marked this pull request as ready for review September 17, 2026 16:42
@JoeTravisKiva
JoeTravisKiva merged commit 1194398 into main Sep 17, 2026
5 of 7 checks passed
kiva-robot added a commit that referenced this pull request Sep 22, 2026
## [3.96.0-rc.1](v3.95.0...v3.96.0-rc.1) (2026-09-22)

### 🎉 New Features

* [MP-3208] - done show goal days left if there 90 days or less t… ([#7265](#7265)) ([f22f4b9](f22f4b9))
* add fundraisers entry point to MyKiva ([#7271](#7271)) ([7b25967](7b25967))
* additional copy edits ([9eeac5f](9eeac5f))
* additional merge fix ([191afb1](191afb1))
* changed copy ([244ce6d](244ce6d))
* corrected revisions ([294d6b8](294d6b8))
* edited unit tests ([2f6e28b](2f6e28b))
* gate the MyKiva fundraisers row behind an experiment ([#7274](#7274)) ([a374c8d](a374c8d))
* increased padding ([4a57d64](4a57d64))
* mp-3158 track the non-express checkout path from lend after goal set ([#7260](#7260)) ([81db98e](81db98e))
* mp-3209 keep completed goal at front until its goal year ends ([#7269](#7269)) ([57d81e3](57d81e3))
* padding only on express checkout context ([7d0f56a](7d0f56a))
* removed img file + label context; prop binding fix ([f6d60f5](f6d60f5))
* revised title format and spec tests context ([d641017](d641017))
* simplified expression ([75119c4](75119c4))

### 🐛 Bugfixes

* **build:** finish the ssr-manifest-css plugin to match quasar's fix ([75638bd](75638bd))
* **build:** link the stylesheets a chunk reaches by static import ([af935d9](af935d9))
* ensure goal summary query is not fired if the user does not meet the conditions to see goal in recap ([575656d](575656d))
* mp-3209 make the recapDate override reach the server so hydration matches ([#7278](#7278)) ([a0e000e](a0e000e))
* reduce duplicate giving fund queries on portfolio ([#7272](#7272)) ([34e2e93](34e2e93))
* rephrase badly worded comments ([ad1b7df](ad1b7df))
* show real copy when the basket is locked by an in-flight checkout ([#7266](#7266)) ([b4944cd](b4944cd))

### 🪚 Refactors

* drop the isEligible argument from shouldAutoOpenRecap ([3c1d786](3c1d786))
* look up the spotlight category by slug ([#7268](#7268)) ([7045ee1](7045ee1))
* reuse shouldAutoOpenRecap instead of splitting it ([8c7cc15](8c7cc15))

### 🔍 Tests

* missing coverage test ([b44f681](b44f681))

### 🧹 Chores

* **deps:** bump @kiva/kv-shop to ^3.8.32 ([#7267](#7267)) ([1194398](1194398))
* **deps:** upgrade kiva packages to latest versions AD-501 AD-506 ([1cda5df](1cda5df))
* drop stale dependabot ignores and auto-assign workflow ([#7273](#7273)) ([a6fde5e](a6fde5e))
@kiva-robot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.96.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kiva-robot added a commit that referenced this pull request Sep 23, 2026
## [3.96.0](v3.95.0...v3.96.0) (2026-09-23)

### 🎉 New Features

* [MP-3208] - done show goal days left if there 90 days or less t… ([#7265](#7265)) ([f22f4b9](f22f4b9))
* add fundraisers entry point to MyKiva ([#7271](#7271)) ([7b25967](7b25967))
* additional copy edits ([9eeac5f](9eeac5f))
* additional merge fix ([191afb1](191afb1))
* changed copy ([244ce6d](244ce6d))
* corrected revisions ([294d6b8](294d6b8))
* edited unit tests ([2f6e28b](2f6e28b))
* gate the MyKiva fundraisers row behind an experiment ([#7274](#7274)) ([a374c8d](a374c8d))
* increased padding ([4a57d64](4a57d64))
* mp-3158 track the non-express checkout path from lend after goal set ([#7260](#7260)) ([81db98e](81db98e))
* mp-3209 keep completed goal at front until its goal year ends ([#7269](#7269)) ([57d81e3](57d81e3))
* padding only on express checkout context ([7d0f56a](7d0f56a))
* removed img file + label context; prop binding fix ([f6d60f5](f6d60f5))
* revised title format and spec tests context ([d641017](d641017))
* simplified expression ([75119c4](75119c4))

### 🐛 Bugfixes

* **build:** finish the ssr-manifest-css plugin to match quasar's fix ([75638bd](75638bd))
* **build:** link the stylesheets a chunk reaches by static import ([af935d9](af935d9))
* ensure goal summary query is not fired if the user does not meet the conditions to see goal in recap ([575656d](575656d))
* mp-3209 make the recapDate override reach the server so hydration matches ([#7278](#7278)) ([a0e000e](a0e000e))
* reduce duplicate giving fund queries on portfolio ([#7272](#7272)) ([34e2e93](34e2e93))
* rephrase badly worded comments ([ad1b7df](ad1b7df))
* show real copy when the basket is locked by an in-flight checkout ([#7266](#7266)) ([b4944cd](b4944cd))

### 🪚 Refactors

* drop the isEligible argument from shouldAutoOpenRecap ([3c1d786](3c1d786))
* look up the spotlight category by slug ([#7268](#7268)) ([7045ee1](7045ee1))
* reuse shouldAutoOpenRecap instead of splitting it ([8c7cc15](8c7cc15))

### 🔍 Tests

* missing coverage test ([b44f681](b44f681))

### 🧹 Chores

* **deps:** bump @kiva/kv-shop to ^3.8.32 ([#7267](#7267)) ([1194398](1194398))
* **deps:** upgrade kiva packages to latest versions AD-501 AD-506 ([1cda5df](1cda5df))
* drop stale dependabot ignores and auto-assign workflow ([#7273](#7273)) ([a6fde5e](a6fde5e))
* **release:** 3.96.0-rc.1 [skip ci] ([1c45283](1c45283)), closes [#7265](#7265) [#7271](#7271) [#7274](#7274) [#7260](#7260) [#7269](#7269) [#7278](#7278) [#7272](#7272) [#7266](#7266) [#7268](#7268) [#7267](#7267) [#7273](#7273)
@kiva-robot

Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.96.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants