feat: revised express checkout copy (MP-3090) - #7270
Merged
Merged
Conversation
tiarascoleman
changed the title
cristhianDt
approved these changes
Sep 17, 2026
cristhianDt
reviewed
Sep 17, 2026
cristhianDt
self-requested a review
September 17, 2026 17:54
dyersituations
requested changes
Sep 17, 2026
dyersituations
left a comment
dyersituations
left a comment
Collaborator
There was a problem hiding this comment.
Mainly see comment about loading state vs loaded state.
roger-in-kiva
approved these changes
Sep 18, 2026
christian14b
approved these changes
Sep 18, 2026
| const depositRequired = computed(() => (numeral(totalDue.value).value() ?? 0) > 0); | ||
| const lightboxTitle = computed(() => (ready.value ? 'Adding to basket' : 'Confirm payment')); |
Collaborator
There was a problem hiding this comment.
This is the opposite of what the ticket requests, it now says "Adding to basket" when the modal is completely loaded:
| const secondaryLabel = computed(() => { | ||
| return props.expressCheckoutEnabled | ||
| ? 'Express checkout' | ||
| ? 'Add to basket' |
Collaborator
There was a problem hiding this comment.
The ticket requests to remove this text, not replace it:
Collaborator
|
Ticket requests this button to change to "Add to basket" |
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket reference: https://kiva.atlassian.net/jira/software/projects/MP/boards/275?filter=&groupBy=none&selectedIssue=MP-3090
Proposed solution: changed copy (the second commit also feature additional cohesive copy edits)
**Proof of testing:**