Skip to content

Skip non-YAML files in check-schema #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnobKumarSaha merged 1 commit into from
Aug 21, 2026
Merged

Skip non-YAML files in check-schema #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions cmd/check-schema/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ limitations under the License.
package main

import (
"fmt"
"io/fs"
"path/filepath"

"kmodules.xyz/resource-metadata/apis/meta/v1alpha1"
uiapi "kmodules.xyz/resource-metadata/apis/ui/v1alpha1"
blockdefs "kmodules.xyz/resource-metadata/hub/resourceblockdefinitions"
Expand All @@ -28,19 +32,37 @@ import (
)

func main() {
if err := sc.CheckFS(blockdefs.EmbeddedFS(), &v1alpha1.ResourceBlockDefinition{}); err != nil {
if err := checkYAMLs(blockdefs.EmbeddedFS(), &v1alpha1.ResourceBlockDefinition{}); err != nil {
panic(err)
}
if err := sc.CheckFS(resourcedescriptors.EmbeddedFS(), &v1alpha1.ResourceDescriptor{}); err != nil {
if err := checkYAMLs(resourcedescriptors.EmbeddedFS(), &v1alpha1.ResourceDescriptor{}); err != nil {
panic(err)
}
if err := sc.CheckFS(resourceoutlines.EmbeddedFS(), &v1alpha1.ResourceOutline{}); err != nil {
if err := checkYAMLs(resourceoutlines.EmbeddedFS(), &v1alpha1.ResourceOutline{}); err != nil {
panic(err)
}
if err := sc.CheckFS(tabledefs.EmbeddedFS(), &v1alpha1.ResourceTableDefinition{}); err != nil {
if err := checkYAMLs(tabledefs.EmbeddedFS(), &v1alpha1.ResourceTableDefinition{}); err != nil {
panic(err)
}
if err := sc.CheckFS(dashboards.EmbeddedFS(), &uiapi.ResourceDashboard{}); err != nil {
if err := checkYAMLs(dashboards.EmbeddedFS(), &uiapi.ResourceDashboard{}); err != nil {
panic(err)
}
}

// hub packages embed a non-YAML "trigger" sentinel file for hot reload,
// which sc.CheckFS would try to parse as an object.
func checkYAMLs(fsys fs.FS, v interface{}) error {
return fs.WalkDir(fsys, ".", func(path string, e fs.DirEntry, err error) error {
if err != nil || e.IsDir() || filepath.Ext(path) != ".yaml" {
return err
}
d, err := sc.New(fsys).CheckObject(v, path)
if err != nil {
return err
}
if d != "" {
return fmt.Errorf("%s: object does not match schema, diff: %s", path, d)
}
return nil
})
}
Loading