Conversation
Contributor
📋 Unreleased Changelog Preview
ChangelogAll notable changes to this project will be documented in this file. [Unreleased]♻️ Refactoring
✨ Features
Generated by git-cliff 🔄 Run #136 · Thu, 06 Aug 2026 11:42:31 GMT |
1 task
Contributor
✅ Test Results
✅ Coverage
🔄 CI run #155 · Thu, 06 Aug 2026 11:45:43 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Adds the
ktestify-coregroundwork needed to support multi-rowDataTable-driven producer/consumer steps inktestify-cucumberwithout reintroducing the offset-skew problem raised in the original discussion.Two independent, composable additions:
TopicUtils.assertSingleTopic(List<Topic>)(newTopicMismatchException) ,a transport-agnostic guard rail that asserts a list of resolvedTopics all point to the same physical topic (namespaced name + type). Any caller driving one physical operation (producer send, consumer fetch) from multipleDataTablerows can reuse this to reject mixed-topic input before doing any work, instead of silently acting on the first row or partially completing.ConsumerContext.referenceTimestamp(nullableLong, epoch ms), when set,KafkaRecordFetcher.calculateDeltaTime()uses it as "now" instead of callingSystem.currentTimeMillis()live at seek time. This lets a caller capture "now" once and reuse it across several sequential fetches, so theirconsumerDeltaTimeseek windows are computed identically instead of drifting apart as earlier fetches take time to complete.Neither change alters existing behavior when unused:
referenceTimestampdefaults tonull(live clock, same as before), andTopicUtilsis a new opt-in utility with no existing call sites in this module.This is the core-side dependency for the
ktestify-cucumberfix to issue #38, the ktestify-cucumber PR buildsConsumerContext/ProducerContextfor eachDataTablerow using these two primitives.Resolves #38
🔄 Type of Change
✅ Pre-Merge Checklist
Code Quality
mvn spotless:check)Tests
mvn verify)Licensing