docs: add format input to README inputs table - #82
Conversation
Signed-off-by: Utkarsh Anand <utkarsha137@gmail.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe README now describes comma-separated ChangesFormat input documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The README accurately describes the format input and resulting output files. No actionable merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matthyx
left a comment
There was a problem hiding this comment.
Approve: the README-only change is needed and consistent with the existing action contract. No blocking findings.
Reviewed head 6bff8b15373fd4f2a06bd23492d603b8ee36a835 against main at d65853c2832df0d379201ceaea331b5820ab9070.
- Necessity: #66 reports the missing input, and the maintainer explicitly endorsed this documentation contribution targeting main. The target README still lacks the row.
action.yml:73–88defines the optional input,junitdefault, comma-separated formats and help command;entrypoint.sh:49–50,89forwards the values. The new row also uses the correctoutputFileinput name. - History: searched all returned PRs (62) and issues (20), across all states, by title/body using
format,sarif,junit,outputFile,READMEanddocumentation; inspected relevant diffs and discussions. #27 added multiple-format metadata, and #18 fixed outputFile forwarding; neither supplies this missing README row. Open #81 edits other README sections and does not supersede this change. Closed #8 says the README had changed, and #73/#74 were already addressed on main, rather than rejecting this approach. No applicable prior rejection found. Search was limited to accessible repository records and selected discussion threads, not exhaustive comment-text search; absence of a match is not proof none exists. - Validation: independently reviewed the exact diff and input-to-CLI path in two review lanes; architecture CLEAR. A local text assertion confirms the base lacks the row and the head adds exactly one three-column row with balanced inline code and the stated examples.
git diff --no-index --checkreported no whitespace errors (exit 1 denotes the differing files). No runtime, container, build or Markdown lint tests were run; none of the execution paths changes here. - CI: DCO, GitGuardian and CodeRabbit succeeded. The autofix job failed at checkout because its existing
pull_request_targetworkflow refuses fork code, before scanning. This is unrelated to the added row; it is not evidence of passing runtime validation. Current branch protection/rules require approval but configure no required status checks. The PR is non-draft and mergeable.
Scope is appropriate: no runtime, API, dependency, permission or configuration changes. The pre-existing metadata typo and missing fixFiles table entry can remain separate. Verdict: APPROVE for the reviewed commit; no merge performed.
Description
This PR adds the missing
formatinput to the Inputs table in the README. The description is based on its definition inaction.yml, including the default value (junit) and support for multiple comma-separated formats.It also points users to
kubescape scan -hfor the complete list of supported formats, which addresses the question raised in the issue about values other thansarif.Related items (out of scope)
While working on this, I noticed two related items that I have left out of this PR to keep its scope focused:
formatdescription inaction.ymlrefers to anoutputinput, but the actual input name isoutputFile.fixFilesinput is used in the README examples but is not listed in the Inputs table.I am happy to open a follow-up PR for these if that would be useful.
Fixes #66
Summary by CodeRabbit
junit.