feat: implements auto targeting of current tree - #192
Open
Niyudi wants to merge 2 commits into
Open
Conversation
Implements first version of auto tree detector, that does everything silently. When applying a patch, if no tree is targeted, it checks if the currenr working directory is a valid branch and targets it. Signed-off-by: Pedro Yudi Honda <niyudi.honda@usp.br>
Changes message to mention the tree was auto detected when it is the case. This way, there is at least some warning to when the system triggers. Signed-off-by: Pedro Yudi Honda <niyudi.honda@usp.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a quick quality of life feature: when a user first applies a patch, if there is no target tree set, it automatically takes the current tree and branch and sets it as the target. Currently, the way to set these attributes is though the config file. As a first fix to facilitate onboarding, this feature avoids confusion on patches failing to apply when first using the program.
Future steps may include adding the config file to the UI, so it can be edited in program, and reworking the flow of patch application so that the tree and branch can be seen/set right before running.