Fixed function exponentiation not being parsed correctly#266
Open
MadScientistBR wants to merge 1 commit into
Open
Fixed function exponentiation not being parsed correctly#266MadScientistBR wants to merge 1 commit into
MadScientistBR wants to merge 1 commit into
Conversation
…(x) -> sec(x)**2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
sec2(x)** and sec^2(x) were treated as invalid. Therefore, the users had to manually write sec(x)^2 to get sec^2(x).
Turns out this was a SymPy parser configuration issue: the function_exponentiation transformation, which rewrites f**n(x) as f(x)**n, isn't enabled by default and has to be explicitly included.
Changes
app/utility/expression_utilities.py: We explicitly pass the function_exponentitation transformation to the SymPy parser in functionparse_expression(line 813 and 815).app/tests/symbolic_evaluation_test.py: added test cases covering all supported trig/hyperbolic functions.Closes issue #257.