Skip to content

refactor: moving signature logic from ethlambda-types to ethlambda-crypto - #541

Draft
Sahilgill24 wants to merge 3 commits into
lambdaclass:mainfrom
Sahilgill24:refactor/signature-logic-port
Draft

refactor: moving signature logic from ethlambda-types to ethlambda-crypto#541
Sahilgill24 wants to merge 3 commits into
lambdaclass:mainfrom
Sahilgill24:refactor/signature-logic-port

Conversation

@Sahilgill24

@Sahilgill24 Sahilgill24 commented Jul 28, 2026

Copy link
Copy Markdown

Description / Motivation

porting the lean-sig based signature logic from types crate to crypto crate as mentioned here

It is first of all a cleaner and more idiomatic approach and secondly ethlambda-types crate builds/compiles for the prover crate(zkVM prover), which also leads to dependency conflicts between leansig dependencies and the zkVM sdk dependencies being used. This port removes all leansig dependencies from the ethlambda-types

What Changed

  • added a new signature.rs file to the crypto crate along with a extension trait ValidatorPublicKeys with the same methods as before, it helps in avoiding cyclic dependencies and the call sites remain the same.
  • removed the older signature.rs from the types crate and moved the SIGNATURE_SIZE directly to the attestation.rs

Verification Checklist

  • Ran make fmt
  • Ran make lint (clippy with -D warnings)
  • Ran cargo test --workspace --release — all passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants