feat(ui): shared confirm/prompt dialogs + list pager on top with typeable page - #14
Closed
jcfrei wants to merge 1 commit into
Closed
feat(ui): shared confirm/prompt dialogs + list pager on top with typeable page#14jcfrei wants to merge 1 commit into
jcfrei wants to merge 1 commit into
Conversation
…able page Replaces window.confirm/window.prompt with a styled dialog system: - <DialogProvider> (mounted by AppShell) + useConfirm()/usePrompt() hooks. - <ConfirmButton>: inline arm-to-confirm for in-row actions — first click splits into Cancel | Confirm with Cancel on the trigger's spot, so a double-click cancels (nothing happens); auto-collapses. - Core submit/cancel (document-actions), master delete, proposal discard, and the invite-link fallback now use these instead of native dialogs. DocumentList pagination now renders above AND below the table (no scroll-to- bottom on long lists), and the page number is an editable field (Enter to jump, clamped 1..last). Extracted into a reusable <ListPager>. All new APIs exported: DialogProvider, useConfirm, usePrompt, ConfirmButton. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jcfrei
added a commit
that referenced
this pull request
Jul 30, 2026
feat(ui): shared confirm/prompt dialogs + list pager on top with typeable page (#14) DialogProvider + useConfirm/usePrompt hooks and an inline ConfirmButton replace window.confirm/prompt across core; DocumentList pager now renders above and below with an editable page number. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Squash-merged into master as 8ffe0c7 and released as v0.6.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native
window.confirm/promptdialogs are ugly and inconsistent, and long lists forced a scroll to the bottom to page.What
Shared dialog system (replaces all native dialogs):
<DialogProvider>(mounted byAppShell) +useConfirm()/usePrompt()hooks → styled, on-brand modals.<ConfirmButton>— inline arm-to-confirm for low-stakes in-row actions. First click splits the control into Cancel | Confirm with Cancel taking the trigger's original position, so an accidental double-click lands on Cancel → nothing happens. Auto-collapses after a few seconds / on pointer-leave.document-actions), master delete, proposal discard, and the invite-link fallback.Pagination on
DocumentList:1..last). Extracted into a reusable<ListPager>.Exports:
DialogProvider,useConfirm,usePrompt,ConfirmButton.Design note
Intentional split by severity: inline
ConfirmButtonfor row-level actions (unobtrusive, double-click-safe), modaluseConfirmfor destructive/top-level ones (deliberate, names the consequence — better than adding inline expansions to already-busy toolbars).🤖 Generated with Claude Code