[2.x] Upgrade TypeScript to v6 and Vitest to v5 - #548
Draft
pataar wants to merge 3 commits into
Draft
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
pataar
force-pushed
the
upgrade-typescript-6-vitest-5
branch
from
September 6, 2026 10:15
fb2754d to
a5641ca
Compare
Vitest 5 no longer evaluates import.meta-based define expressions in its worker, so the guarded VITE_* replacements are now skipped under Vitest; tests run with a real import.meta.env and need no replacement. Claude-Session: https://claude.ai/code/session_01PqjbbMAW7txB4AQ3wp2gWD
pataar
force-pushed
the
upgrade-typescript-6-vitest-5
branch
from
September 6, 2026 10:19
a5641ca to
90a45b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades both TypeScript and Vitest to the latest version. The Vitest major had some problems with the code that nullifies the custom env vars. So had to exclude those.