Skip to content

docs(release): read catalog schema version from any runtime file - #197

Merged
samzong merged 1 commit into
mainfrom
docs/release-catalog-schema-source
Oct 4, 2026
Merged

samzong merged 1 commit into
mainfrom
docs/release-catalog-schema-source

Conversation

@samzong

@samzong samzong commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

What's changed?

  • The release skill reads CatalogSchemaVersion from pkg/runtime/*.go instead of pkg/runtime/catalog.go.

Why

  • The constant lives in pkg/runtime/catalog_schema.go. Reading catalog.go yields an empty value, so every jq --argjson schema "$CATALOG_SCHEMA" check in the release gate fails with "invalid JSON text passed to --argjson".

Verification

  • Old command prints an empty value; new command prints 29, matching pkg/runtime/catalog_schema.go:3.
  • The v0.6.3 release gate ran with the corrected path and all generated CLI catalog checks passed.
  • make check passes.

Signed-off-by: samzong <samzong.lu@gmail.com>
@ghfind-review ghfind-review Bot added the review: top ghfind author score; see https://ghfind.com label Oct 4, 2026
@codspeed

codspeed Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 21 untouched benchmarks


Comparing docs/release-catalog-schema-source (4aeac4f) with main (68b28df)

Open in CodSpeed

@samzong
samzong marked this pull request as ready for review October 4, 2026 05:21
@samzong
samzong merged commit 37b49ba into main Oct 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review: top ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant