Skip to content

feat: Add async hook, plugin, and flag tracker#463

Open
jsonbailey wants to merge 1 commit into
mainfrom
jb/sdk-2737/async-hooks-plugins-tracker
Open

feat: Add async hook, plugin, and flag tracker#463
jsonbailey wants to merge 1 commit into
mainfrom
jb/sdk-2737/async-hooks-plugins-tracker

Conversation

@jsonbailey

@jsonbailey jsonbailey commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Overview

This slice adds the async counterparts of the SDK's hook and plugin extension points, plus the async flag tracker used by the async client:

  • AsyncHook (ldclient/hook.py) — abstract base for async hooks. before_evaluation / after_evaluation are coroutines awaited by the async client.
  • AsyncPlugin (ldclient/plugin.py) — abstract base for async plugins. register() is a coroutine (allowing async initialization such as connecting to telemetry backends); get_hooks() remains synchronous and returns AsyncHook instances.
  • AsyncFlagTrackerImpl / AsyncFlagValueChangeListener (ldclient/impl/async_flag_tracker.py) — the async flag tracker implementation.

Unit tests are added in ldclient/testing/test_async_hooks.py and ldclient/testing/test_async_flag_tracker.py.

The async public classes carry the experimental .. caution:: block, matching the rest of the async surface.

This PR depends only on already-merged foundation work and can be reviewed independently.

Tracked internally: SDK-2737


Note

Low Risk
Additive experimental async APIs and new implementation files; no changes to sync client evaluation or existing plugin contracts.

Overview
Adds experimental async extension points and flag-change tracking for AsyncLDClient, paralleling the existing sync Hook, Plugin, and FlagTrackerImpl.

AsyncHook in hook.py mirrors Hook but with async before_evaluation / after_evaluation coroutines the async client will await. AsyncPlugin in plugin.py adds an async register() for AsyncLDClient and synchronous get_hooks() returning AsyncHook instances only (with AsyncHook imported alongside Hook).

AsyncFlagTrackerImpl and AsyncFlagValueChangeListener implement async flag-value change listeners: baseline evaluation on subscribe (no initial callback), re-evaluation on matching FlagChange events, deduplication when the value is unchanged, and scheduling via AsyncCallbackScheduler so notifications work from worker threads without a running loop.

Unit tests cover hook dispatch order (before forward, after reverse), per-hook isolated hook data, and tracker add/remove/thread-notify behavior.

Reviewed by Cursor Bugbot for commit 9869242. Bugbot is set up for automated code reviews on this repo. Configure here.

@jsonbailey
jsonbailey force-pushed the jb/sdk-2737/async-hooks-plugins-tracker branch from bc1d428 to f0bd132 Compare July 21, 2026 20:27
@jsonbailey
jsonbailey changed the base branch from jb/sdk-2729/async-big-segments to main July 21, 2026 20:27
@jsonbailey
jsonbailey force-pushed the jb/sdk-2737/async-hooks-plugins-tracker branch from f0bd132 to cc93fc2 Compare July 21, 2026 20:47
@jsonbailey
jsonbailey marked this pull request as ready for review July 21, 2026 21:19
@jsonbailey
jsonbailey requested a review from a team as a code owner July 21, 2026 21:19

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cc93fc2. Configure here.

Comment thread ldclient/impl/async_flag_tracker.py
@jsonbailey
jsonbailey force-pushed the jb/sdk-2737/async-hooks-plugins-tracker branch from cc93fc2 to 9869242 Compare July 21, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant