ci: trigger the Docker image publish from GitHub Releases, not tag pushes#657
Open
ddeboer wants to merge 1 commit into
Open
ci: trigger the Docker image publish from GitHub Releases, not tag pushes#657ddeboer wants to merge 1 commit into
ddeboer wants to merge 1 commit into
Conversation
…shes - A multi-package nx release pushes all its tags in one batch, and GitHub emits no tag-push events at all when more than three tags arrive at once – so the tag trigger silently never fired (observed on the release that tagged 12 packages: zero Docker runs) - Trigger on the GitHub Releases nx release creates instead (one event per package, no batch suppression), with a job guard passing only the image-shipping packages - workflow_dispatch stays as the manual escape hatch - Align ADR 15/16 and the package READMEs with the new trigger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Docker workflow shipped in #646 never fired on release: a multi-package
nx releasepushes all its tags in one batch, and GitHub emits no tag-push events at all when more than three tags arrive at once. Today’s release pushed 12 tags – zero Docker runs (the 0.0.1 images were published viaworkflow_dispatchinstead).Trigger on the GitHub Releases nx release creates instead (
release: types: [published]): one event per package, created with the PAT so events fire, no batch suppression. A job-level guard passes only the image-shipping packages (search-api-server,search-indexer) – every other package’s release event skips the job. For release eventsgithub.ref_nameis the tag name, so the existing checkout/version steps work unchanged.workflow_dispatchstays as the manual escape hatch.Also aligns ADR 15/16 and the two package READMEs with the new trigger.