[Merged by Bors] - feat(Tactic): add multiplication support for inclusion/dyadic_interval tactics - #43563
Closed
DavidLedvinka wants to merge 41 commits into
Closed
Conversation
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Thomas R. Murrills <68410468+thorimur@users.noreply.github.com>
# Conflicts: # Mathlib/Tactic/Linter/DeprecatedSyntaxLinter.lean
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
added 11 commits
September 2, 2026 19:49
…ication # Conflicts: # Mathlib/Tactic/Inclusion/Core/DiscrTreeExt.lean # Mathlib/Tactic/Inclusion/Core/Elab.lean # Mathlib/Tactic/Inclusion/Extension/Interval.lean # Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Basic.lean # Mathlib/Tactic/Inclusion/Extension/IntervalDyadicReal/Tactic.lean
github-actions
Bot
added
the
large-import
PR summary 3dab67ecd3Import changes exceeding 2%
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.Tactic.Inclusion.Extension.Interval | 336 | 389 | +53 (+15.77%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.Tactic.Inclusion.Extension.Interval |
53 |
Declarations diff (regex)
+ Interval.map_mulBound_le
+ Interval.mem_map_iff
+ Interval.mul
+ Interval.mulBound
+ Interval.mul_mem
+ mul_le_mul_of_nonpos_of_nonneg''
+ mul_mem
You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.
Declarations diff (Lean)
✅ Lean-aware diff — post-build, computed from the Lean environment (commit
3dab67e).
- +20 new declarations
- −0 removed declarations
+Inclusion.Interval.add.match_1.congr_eq_1
+Inclusion.Interval.add.match_1.congr_eq_2
+Inclusion.Interval.add.match_4.congr_eq_1
+Inclusion.Interval.add.match_4.congr_eq_2
+Inclusion.Interval.le_map_mulBound
+Inclusion.Interval.map_mulBound_le
+Inclusion.Interval.mem_map_iff
+Inclusion.Interval.mul
+Inclusion.Interval.mulBound
+Inclusion.Interval.mul_mem
+Inclusion.Interval.neg.match_1.congr_eq_1
+Inclusion.Interval.neg.match_1.congr_eq_2
+Inclusion.Interval.neg.match_3.congr_eq_1
+Inclusion.Interval.neg.match_3.congr_eq_2
+Inclusion.Interval.sub.match_1.congr_eq_1
+Inclusion.Interval.sub.match_1.congr_eq_2
+Inclusion.Interval.sub.match_3.congr_eq_1
+Inclusion.Interval.sub.match_3.congr_eq_2
+Inclusion.IntervalDyadicReal.mul_mem
+mul_le_mul_of_nonpos_of_nonneg''No changes to strong technical debt.
No changes to weak technical debt.
Current commit 3dab67ecd3
Reference commit 059a625dc0
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
✅ PR Title Formatted CorrectlyThe title of this PR has been updated to match our commit style conventions. |
DavidLedvinka
changed the title
inclusion/dyadic_interval tacticsinclusion/dyadic_interval tactics
DavidLedvinka
added
the
awaiting-CI
github-actions
Bot
removed
the
awaiting-CI
Contributor
|
Thanks! bors merge |
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Sep 8, 2026
…rval` tactics (#43563) Also in the process of proving/golfing the `mul_mem` lemma some local grind tags were added which were then used to do a little bit of golfing for other proofs. Note: There is some intentional defeq abuse with the input and output type of `mulBound` This seems fine to me but alternatively there could be eight different functions in place of the single `mulBound` to avoid this. Co-authored-by: David Ledvinka <dledvinka.ledvinka@mail.utoronto.ca>
mathlib-bors
Bot
added
the
bors-staging
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
inclusion/dyadic_interval tacticsinclusion/dyadic_interval tactics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also in the process of proving/golfing the
mul_memlemma some local grind tags were added which were then used to do a little bit of golfing for other proofs.Note: There is some intentional defeq abuse with the input and output type of
mulBoundThis seems fine to me but alternatively there could be eight different functions in place of the singlemulBoundto avoid this.