refactor(CategoryTheory): insert missing Functor.op compatibility isomorphisms - #43567
Open
kim-em wants to merge 1 commit into
Open
refactor(CategoryTheory): insert missing Functor.op compatibility isomorphisms#43567kim-em wants to merge 1 commit into
kim-em wants to merge 1 commit into
Conversation
PR summary 312f6cf987Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| backward.defeqAttrib.useBackward | 4245 | -1 |
| erw | 497 | 1 |
Current commit 312f6cf987
Reference commit 572e4d091b
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
…morphisms Use Functor.opId, Functor.opComp and the new Functor.leftOpCompOp where the opposite of a composition or identity was identified with the composition of opposites by unfolding, and state the units and counits of Adjunction.op, unop, leftOp and rightOp componentwise. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR inserts
Functor.opId,Functor.opCompand the newFunctor.leftOpCompOpwhere Mathlib currently identifies(F ⋙ G).opwithF.op ⋙ G.op,(𝟭 C).opwith𝟭 Cᵒᵖ, or(F ⋙ G.op).leftOpwithF.leftOp ⋙ Gby unfoldingFunctor.op, and states the units and counits ofAdjunction.op,unop,leftOpandrightOpcomponentwise rather than asNatTrans.op/NatTrans.unopat a type that only matches after unfolding. The unit and counit ofopOpEquivalenceare likewise built from components. The affected declarations areopShiftFunctorEquivalence,SimplicialObject.opFunctorCompOpFunctorIsoandLimits.exists_eq_isColimitMap_of_preservesColimit_coyoneda.It is extracted from Paul Reichert's experiment making
Functor.compandFunctor.idinstance_reducible(master...leanprover-community:mathlib4-nightly-testing:datokrat/functorcomp, discussed at https://leanprover.zulipchat.com/#narrow/channel/113488-general/topic/backward.2EisDefEq.2ErespectTransparency), keeping only theFunctor.opfixes; the associator and unitor fixes are in #43566.🤖 Prepared with Claude Code