Skip to content

chore(CategoryTheory/Limits/Shapes/BinaryProducts): use to_dual - #43571

Open
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-BinaryProducts
Open

chore(CategoryTheory/Limits/Shapes/BinaryProducts): use to_dual#43571
JovanGerb wants to merge 2 commits into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-BinaryProducts

Conversation

@JovanGerb

@JovanGerb JovanGerb commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This PR uses to_dual on binary products/coproducts.

  • BinaryFan.fst/snd have been given an explicit type annotation so that the type doesn't involve Functor.const.

Open in Gitpod

@JovanGerb JovanGerb added the WIP Work in progress label Sep 8, 2026
@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

PR summary 3cbcf125ae

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ BinaryFan.ext_inv_hom
+ Discrete.Hom.casesOn'
- BinaryCofan
- BinaryCofan.IsColimit.hom_ext
- BinaryCofan.IsColimit.mk
- BinaryCofan.ext
- BinaryCofan.ext_hom_hom
- BinaryCofan.inl
- BinaryCofan.inr
- BinaryCofan.isColimitMk
- BinaryCofan.mk
- BinaryCofan.mk_inl
- BinaryCofan.mk_inr
- BinaryCofan.ι_app_left
- BinaryCofan.ι_app_right
- isoBinaryCofanMk

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


Decrease in strong tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (strong)
backward.defeqAttrib.useBackward 4245 -1
No changes to weak technical debt.

Current commit 3cbcf125ae
Reference commit 059a625dc0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-category-theory Category theory label Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-category-theory Category theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip WIP Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant