Skip to content

refactor(RingTheory/Multiplicity): switch multiplicity to have junk value of 0 - #43573

Open
tb65536 wants to merge 5 commits into
leanprover-community:masterfrom
tb65536:tb_mult93
Open

refactor(RingTheory/Multiplicity): switch multiplicity to have junk value of 0#43573
tb65536 wants to merge 5 commits into
leanprover-community:masterfrom
tb65536:tb_mult93

Conversation

@tb65536

@tb65536 tb65536 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This PR switches multiplicity to have a junk value of 0. This is more consistent with the rest of mathlib and valuations.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Sep 8, 2026
@github-actions github-actions Bot added the tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

PR summary 574671eb26

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ emultiplicity_eq_iff_multiplicity_eq_of_ne_zero
+ multiplicity_eq_zero_of_not_dvd
+ multiplicity_eq_zero_of_not_finiteMultiplicity

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 574671e).

  • +3 new declarations
  • −0 removed declarations
+emultiplicity_eq_iff_multiplicity_eq_of_ne_zero
+multiplicity_eq_zero_of_not_dvd
+multiplicity_eq_zero_of_not_finiteMultiplicity

Decrease in strong tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (strong)
backward.isDefEq.respectTransparency 4678 -1
No changes to weak technical debt.

Current commit 574671eb26
Reference commit 1d97a98f34

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Sep 8, 2026
@tb65536
tb65536 requested a review from b-mehta September 8, 2026 13:25
Comment thread Mathlib/RingTheory/Multiplicity.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) t-number-theory Number theory (also use t-algebra or t-analysis to specialize) t-ring-theory Ring theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants