Skip to content

feat(AffineSpace): toAffineSubspace lemmas - #43582

Open
vlad902 wants to merge 3 commits into
leanprover-community:masterfrom
vlad902:toaffinesubspace-lemmas
Open

feat(AffineSpace): toAffineSubspace lemmas#43582
vlad902 wants to merge 3 commits into
leanprover-community:masterfrom
vlad902:toaffinesubspace-lemmas

Conversation

@vlad902

@vlad902 vlad902 commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Open in Gitpod

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

PR summary d218829e52

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ affineSpan_eq_span_iff_zero_mem
+ coe_toAffineSubspace
+ dim_toAffineSubspace
+ finDim_toAffineSubspace
+ toAffineSubspace_ne_bot

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit d218829).

  • +5 new declarations
  • −0 removed declarations
+AffineSubspace.dim_toAffineSubspace
+AffineSubspace.finDim_toAffineSubspace
+AffineSubspace.toAffineSubspace_ne_bot
+Submodule.coe_toAffineSubspace
+affineSpan_eq_span_iff_zero_mem

No changes to strong technical debt.
No changes to weak technical debt.

Current commit d218829e52
Reference commit 9b46e33ce0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

-- Let's delete `spanPoints`
@[simp]
lemma affineSpan_insert_zero (s : Set V) :
(affineSpan k (insert 0 s) : Set V) = Submodule.span k s := by

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the previous coercion version of this lemma is now by simp.

Comment thread Mathlib/LinearAlgebra/AffineSpace/AffineSubspace/Defs.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants