chore(Algebra/QuadraticAlgebra): define natCast and intCast without C - #43583
chore(Algebra/QuadraticAlgebra): define natCast and intCast without C#43583xroblot wants to merge 1 commit into
Conversation
PR summary 40e78fbe18Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
|
!radar |
|
👎 Rejected by label |
|
Whhops, too fast. But I do like the look of this. |
|
@jcommelin I still want to do some testing before merging this PR |
|
Benchmark results for 40e78fb against 9b46e33 are in. No significant results found. @xroblot
No significant changes detected. |
|
@jcommelin Timings are fine so this PR is ready to be merged if you want to |
The
natCastandintCastfields go throughQuadraticAlgebra.C, which is opaque at implicit transparency, soRing.toIntAlgebraandinstAlgebraare not defeq forrw. Writing them as⟨n, 0⟩fixes it, as #43242 did foralgebraMap.Prepared with Claude Code 🤖