Skip to content

chore: make a few lemmas using in RingHomClass definitions take in a concrete morphism - #43585

Open
grunweg wants to merge 4 commits into
leanprover-community:masterfrom
grunweg:concrete-lemmas2
Open

chore: make a few lemmas using in RingHomClass definitions take in a concrete morphism#43585
grunweg wants to merge 4 commits into
leanprover-community:masterfrom
grunweg:concrete-lemmas2

Conversation

@grunweg

@grunweg grunweg commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Ideal.map and Ideal.comap are such definitions

Part of #31365:

Given a definition Bar that takes FooHom as an argument, a theorem whose statement involves Bar should only ever be written for FooHoms and never FooHomClasses. Indeed in the latter case, the statement would require the coercion from the morphism class to the morphism, thereby making it less general.


Open in Gitpod

@grunweg grunweg added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

PR summary f3ad5d8978

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- pending)

Computed after the build finishes.


Increase in strong tech debt: (relative, absolute) = (2.00, 0.00)
Current number Change Type (strong)
erw 498 2
No changes to weak technical debt.

Current commit f3ad5d8978
Reference commit 38f65a093a

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.py pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Sep 8, 2026
@grunweg grunweg added tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip and removed t-ring-theory Ring theory labels Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant