feat: add Html type - #14935
Open
Vtec234 wants to merge 9 commits into
Open
feat: add Html type#14935Vtec234 wants to merge 9 commits into
Vtec234 wants to merge 9 commits into
Conversation
github-actions
Bot
added
toolchain-available
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
mathlib-lean-pr-testing
Bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Aug 31, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Aug 31, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Aug 31, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 2, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Sep 2, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Sep 2, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 2, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Sep 2, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Sep 2, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 2, 2026
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Sep 2, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Sep 2, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 2, 2026
Vtec234
added this pull request to stack #15148
September 13, 2026 20:44
Vtec234
marked this pull request as ready for review
September 13, 2026 20:56
|
The adaptation PR for this PR is leanprover/downstream-lean4#25. |
Vtec234
added
changelog-library
|
|
||
| namespace Lean | ||
|
|
||
| /-- A forest of HTML trees. |
Contributor
There was a problem hiding this comment.
Suggested change
| /-- A forest of HTML trees. | |
| /-- | |
| A forest of HTML trees. |
Contributor
There was a problem hiding this comment.
I would also expand this a little bit, because "forest of trees" may not be immediately obvious.
What about something like:
HTML content, which may be either a single node or a sequence of sibling nodes.
Member
Author
There was a problem hiding this comment.
Changed wording. To clarify - why does the newline matter?
| This type is optimized for convenient authoring of HTML documents. | ||
| It is not formally related to | ||
| the [HTML DOM representation](https://html.spec.whatwg.org/dev/dom.html). | ||
| It is analogous to React's [Fragment](https://react.dev/reference/react/Fragment). -/ |
Contributor
There was a problem hiding this comment.
Suggested change
| It is analogous to React's [Fragment](https://react.dev/reference/react/Fragment). -/ | |
| It is analogous to React's [Fragment](https://react.dev/reference/react/Fragment). | |
| -/ |
How stable is that link? We don't yet have a link checker as part of Lean CI for external links.
Member
Author
There was a problem hiding this comment.
It has existed since 2023. React have moved their docs across domains once already, although the old link from 2018 (https://reactjs.org/docs/fragments.html) continues to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a type
Lean.Data.Htmlof HTML forests — aimed primarily at authoring HTML (as opposed to internal representation in a web server, etc) — as well as a renderer that produces aStringobject.Rendering directly into
FS.Streamis out of scope for this PR.Downstream adoption (not merely adaptation to make CI pass) PRs that use the new type and renderer: