CI answers for a pull request, and nothing else - #67
Closed
leeovery wants to merge 1 commit into
Closed
Conversation
A bare `push:` ran the matrix on every commit to every branch — a feature branch mid-work piled up runs saying nothing, and the tag push re-ran a tree that had already passed as a PR and would pass preflight again at release. The pull request is the moment the answer is read, so it is the only trigger left. CLAUDE.md's two claims about the trigger move with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Superseded: the workflow is being removed, not retriggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push:trigger fromci.yml, leavingpull_request:alone. A barepush:ran the full matrix on every commit to every branch, so a feature branch mid-work piled up runs that nobody read — and it fired on tag pushes too, re-testing a tree that had already passed as a PR and that.mint.toml's preflight re-checks at release anyway.dash+kshfortests/test_shim.py— shells a Mac doesn't have, where the suite otherwise skips silently.CLAUDE.mdthat claimed "every push and PR". The anti-drift rules require the workflow and the Development section to agree.Test plan
ruff check,ty check,ruff format --check .— clean.pytest -m "not live"— 2041 passed, 15 deselected.{'pull_request': None}.pull_requeststill fires, and no second run against the branch tip showspushis gone.Note
mainhas no green CI run of its own — last night's was cancelled, and after this nothing will ever give it one. Accepted trade: ifmaindrifts between a PR's last pass and its merge, nothing re-checks the combination until the next PR or preflight at release.