fix: replace async-exit-hook with exit-hook to preserve process.exitCode - #31
Open
AmineMaila wants to merge 1 commit into
Open
fix: replace async-exit-hook with exit-hook to preserve process.exitCode#31AmineMaila wants to merge 1 commit into
AmineMaila wants to merge 1 commit into
Conversation
mgray88
added a commit
to first-quality-books/embedded-postgres
that referenced
this pull request
Aug 25, 2026
…ster async-exit-hook calls `process.exit(0)` unconditionally once its hooks have run, discarding whatever `process.exitCode` the application set: a vitest run that fails while a cluster is up reports success. It has also been unmaintained since 2019 and ships no types. exit-hook preserves the exit code and needs no completion callback, which retires the `done` guard from the previous commit. Taken on its own, though, it trades one line of exit noise for another. It prints a SYNCHRONOUS TERMINATION NOTICE on every explicit `process.exit()` for as long as an asynchronous hook is registered, and registering one at import time puts that warning on the exit of every process that loads this module, running cluster or not. So the hook is attached per running cluster instead: `start()` attaches it, `stop()` detaches the last one, and a postmaster that dies on the way up is untracked rather than left for `gracefulShutdown` to wait out its timeout on. An embedder that stops its clusters before exiting now exits silently, and the warning means what it says when a postmaster really is about to be orphaned. `instances` tracks running clusters rather than constructed ones for the same reason. engines.node moves to >=20, which is what exit-hook@5 requires. The new tests run the scenarios in a child process, because every guarantee here is about a process on its way out; `beforeEach` also moves to vitest from `node:test`, where it was registering with a runner that never ran it. Refs leinelissen#31
|
Hi, is there any recent update on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
async-exit-hookwithexit-hookto fix a bug whereprocess.exitCodewas always overridden to0on process exit.async-exit-hookunconditionally callsprocess.exit(0)after its cleanup hooks run, ignoring anyprocess.exitCodeset by the application. Theexit-hookpackage (by the same author, sindresorhus) hooks into process exit events without forcing the exit code, preserving whateverprocess.exitCodewas set.I encountered this while using vitest and embedded-postgres together for testing — when a test failed, vitest sets
process.exitCode = 1, butasync-exit-hookwould force it back to0, causing CI pipelines to incorrectly report the test run as successful.Changes
packages/embedded-postgres/package.json: Replacedasync-exit-hookdependency withexit-hookpackages/embedded-postgres/src/index.ts: Updated import fromAsyncExitHooktoasyncExitHook, removed thedonecallback parameter fromgracefulShutdown, added a 5-second wait timeoutpackages/embedded-postgres/tests/index.test.ts: Added test verifying thatprocess.exitCodeis preserved when usingEmbeddedPostgrespackages/embedded-postgres/tests/helpers/exit-code-test.mjs: Helper script for the exit code testTesting
EmbeddedPostgreswithprocess.exitCode = 42exits with code 42 (not 0)