Add prerelease self-upgrade flag - #424
Merged
Merged
Conversation
Contributor
Reviewer's GuideImplements an opt-in prerelease self-upgrade path by plumbing a --pre flag from the CLI into the binary upgrader, extending the GitHub registry client to select the latest non-draft prerelease, and updating tests and docs accordingly. Sequence diagram for prerelease self-upgrade flowsequenceDiagram
actor User
participant CobraCommand as CobraCommand_upgrade
participant BinaryUpgrader
participant RepoRegistry as GithubRegistry
User->>CobraCommand: lets self upgrade --pre
CobraCommand->>CobraCommand: Flags().GetBool(pre)
CobraCommand->>CobraCommand: upgrade.WithPrerelease
CobraCommand->>BinaryUpgrader: NewBinaryUpgrader(registry, version, options)
User->>BinaryUpgrader: Upgrade(ctx)
BinaryUpgrader->>BinaryUpgrader: latestVersion(ctx)
BinaryUpgrader->>RepoRegistry: GetLatestPrerelease(ctx)
RepoRegistry-->>BinaryUpgrader: tagName
BinaryUpgrader->>RepoRegistry: DownloadReleaseBinary(ctx, packageName, tagName, os, arch)
RepoRegistry-->>BinaryUpgrader: binary
BinaryUpgrader->>BinaryUpgrader: backupExecutable
BinaryUpgrader->>BinaryUpgrader: replaceExecutable
BinaryUpgrader-->>User: upgraded prerelease installed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
kindermax
marked this pull request as ready for review
July 29, 2026 11:09
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider exposing a sentinel error (e.g.
var ErrNoPrerelease = errors.New(...)) for theno prerelease foundcase inGetLatestPrereleaseInfoso callers can distinguish it from other failures without relying on error message text. - The prerelease lookup currently fetches only the first 100 releases (
per_page=100) without pagination, which may miss the true latest prerelease on repos with many releases; consider adding pagination or documenting this limitation if it’s acceptable.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider exposing a sentinel error (e.g. `var ErrNoPrerelease = errors.New(...)`) for the `no prerelease found` case in `GetLatestPrereleaseInfo` so callers can distinguish it from other failures without relying on error message text.
- The prerelease lookup currently fetches only the first 100 releases (`per_page=100`) without pagination, which may miss the true latest prerelease on repos with many releases; consider adding pagination or documenting this limitation if it’s acceptable.
## Individual Comments
### Comment 1
<location path="internal/upgrade/registry/registry.go" line_range="253-262" />
<code_context>
+ url := reg.apiURI + "/releases?per_page=100"
</code_context>
<issue_to_address>
**issue:** Hard-coded per_page=100 may miss the actual latest prerelease if there are many releases
Using GitHub’s max `per_page=100` is fine, but if a repo has >100 releases, you may miss a newer prerelease on later pages and pick an older one. If this is plausible for your use case, either document that only the first 100 releases are considered or add basic pagination (e.g., follow `Link` headers up to a sane page limit).
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+253
to
+262
| url := reg.apiURI + "/releases?per_page=100" | ||
|
|
||
| req, err := http.NewRequestWithContext( | ||
| requestCtx, | ||
| http.MethodGet, | ||
| url, | ||
| nil, | ||
| ) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to create request: %w", err) |
Contributor
There was a problem hiding this comment.
issue: Hard-coded per_page=100 may miss the actual latest prerelease if there are many releases
Using GitHub’s max per_page=100 is fine, but if a repo has >100 releases, you may miss a newer prerelease on later pages and pick an older one. If this is plausible for your use case, either document that only the first 100 releases are considered or add basic pagination (e.g., follow Link headers up to a sane page limit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an opt-in
lets self upgrade --preflag for upgrading to the latest GitHub prerelease while leaving the defaultlets self upgradepath on stable releases.Changes
--preonlets self upgrade.Validation
lets fmtgo test ./...lets test-bats no_lets_file.batslets lintgo run ./cmd/lets self upgrade --helpSummary by Sourcery
Add support for upgrading the CLI to prerelease versions and wire it through the self-upgrade command and docs.
New Features:
Documentation:
Tests: