Repository navigation
bin/release no longer crashes on gh's stderr hints - #63
Merged
Merged
Conversation
gh 2.105 writes hint: lines on stderr, which run mixed into the JSON of gh pr view, so the release crashed right after opening its pull request. stderr is now shown only when a command fails. Assisted-by: Claude [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh 2.105 writes
hint:lines on stderr.runcaptured stdout and stderr together, so the JSON ofgh pr viewcame back with a hint in front of it and the release crashed right after opening its pull request.runnow returns stdout alone and shows stderr only when the command fails. The same change goes to the five gems, keepingbin/releaseidentical.runparses: JSON, branch names, commit ids,git status.--check,--notesand--titlenever callrun.Check
With a stub
ghthat printshint: somethingon stderr and JSON on stdout,JSON.parse(run("gh", "pr", "view"))returns the Hash; a command that fails still prints both streams. RuboCop is clean.Siblings: levups/super-slim, levups/gamba, levups/agentry, levups/maptain, same branch.
Generated by Claude Code