Repository navigation
The bench runs 8 processes by default and rounds ties to even - #123
Merged
Merged
Conversation
gh 2.105 writes hint: lines on stderr, which run mixed into the JSON of gh pr view, so the release crashed right after opening its pull request. stderr is now shown only when a command fails. Assisted-by: Claude [Claude Code]
Eight is a multiple of the four columns, so the Williams design balances every order; seven repeated the first three. The median of an even count now rounds half to even instead of always up. Assisted-by: Claude [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bench balances its column order with a Williams design, which needs a multiple of the four columns to balance every round: the default of 7 repeated the first three orders. The median of an even count also always rounded ties up.
BENCH_PROCESSESnow defaults to 8 and the median rounds half to even, ahead of the rebench before 2.1.0.round(half: :even)for integer measures,round(1, half: :even)for times and memory.docs/benchmarks.htmlno longer states a process count; the footnote already reads it fromdocs/benchmarks.json.Check
2.5.round(half: :even)is 2,3.5is 4; RuboCop is clean.docs/benchmarks.jsonis left as is: it is measured on an idle Mac before the release.Generated by Claude Code