Repository navigation
Generator: tracks 2-4 to Seq, scene mutes cleared, instruments on the project's channels - #36
Merged
Merged
Conversation
…truments on the project's channels - Ambient, styles and the musical arrangement switch the tracks they write (2-4) to Seq (setArpOn, track p86 bit 0x40): a track left on its arpeggiator arpeggiated the generated notes instead of playing them. Arp settings are kept. - The scenes the generator writes lose their mutes (writeScene writes p77); the window text and the manual say so. - Each instrument listens on the track's effective channel: the project's override (0x78 p123) when set, else 1-4, drums on 10 (effectiveChannel); the Rec channel follows it. - Tests: gen_test 11 (arp off and mutes cleared for every generator, track 1 only leaves the others alone), projectmap_test 10 (effectiveChannel). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…e confirm, close warning, hover card) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ss, write confirm, close warning, hover card)" This reverts commit 972e8b2.
… length In drum view the STEPS display showed the sequencer pattern length of track 1 (15 next to END 14), and the END line had no grip. The grip is drawn and dragged as in the note grid (the END line and the grip change the length too). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… pattern length" This reverts commit 3cb0b3d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Leo
Fixes in the generator found after decoding the arpeggiator, the scene mutes and the per-project MIDI channels on the device (2026-11-03). Needed before 0.6.0.
Changes
setArpOn, track param 86 bit 0x40). Before, a track left on Arp arpeggiated the generated notes instead of playing them. The arp settings (mode, octave, division, swing) are kept.writeScenewrites param 77). Now said in the Generate window and in the manual.effectiveChannel). The Rec channel follows it. Before, the engine always used 1-4 / 10, so a track set to channel 7 in the Project Map did not reach its instrument.Tests
ctest), the frozen ambient hash included.effectiveChannel).🤖 Generated with Claude Code