Skip to content

docs/ui/login-page.md lists a deploy-showcase.tsx that does not exist and misses three login components #1098

Description

@kaya-abdullah

What

The ## Files table in docs/ui/login-page.md lists src/components/login/deploy-showcase.tsx, which does not exist in the repository. It also leaves out three components that src/app/login/login-form.tsx imports and renders: hero-proof.tsx, connection-signature.tsx and wire-compatible-line.tsx. The first two are already described further down the same page, in the "Changing the engine and channel lists" table.

Where

docs/ui/login-page.md:187

| src/components/login/deploy-showcase.tsx | Live install channels by group, both surfaces, from the generated inventory |

src/app/login/login-form.tsx:14-17

import { ConnectionSignature } from "@/components/login/connection-signature";
import { DatabaseShowcase } from "@/components/login/database-showcase";
import { HeroProof, HERO_CLAIMS } from "@/components/login/hero-proof";
import { WireCompatibleLine } from "@/components/login/wire-compatible-line";

Expected

Every path in the Files table exists, and every component under src/components/login/ has a row.

How to fix

  1. Remove the deploy-showcase.tsx row.
  2. Add one row each for src/components/login/hero-proof.tsx, src/components/login/connection-signature.tsx and src/components/login/wire-compatible-line.tsx.
  3. Take each purpose from the docblock above the exported component and from the "Changing the engine and channel lists" table, and keep it to one short line like the rows around it.

How to check

  • ls src/components/login/ lists the same four component files the Files table does.
  • ls <path> succeeds for every path in the table.

Curated for Hacktoberfest 2026. Comment to claim the issue before you start so two people do not
work on the same change. A PR must reference the issue and include tests for executable changes;
see CONTRIBUTING.md.
Run bun run test, never bare bun test over a directory: the runner gives each test file its own
process, and bun test tests/api shares one, where a mock set up by one file leaks into the next.
The 100% line-coverage gate must stay green.

CI is the merge gate. If you cannot run a command locally, list that command and the reason
under a Testing heading in your PR body; submit the PR, and a maintainer will approve the fork's
workflow run so CI can verify it. You do not need to withdraw correct work because a local tool
is unavailable.

If your sandbox can reach the npm registry, npm install -g bun is another way to install Bun.
Helm is only needed to run the chart tests: without it bun run test leaves those files out and names them, and CI runs them.
The repository's devcontainer provides Bun and Helm and installs the JavaScript and chart dependencies automatically.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentationgood first issueGood for newcomershacktoberfestCurated for Hacktoberfest; pick up cold, tests required

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions