fix(monitoring): send the table's container with the maintenance target

[sloemo01]

What

Clicking Analyze, Vacuum or Reindex on the monitoring page answered

relation "public.Mytable" does not exist

for every table outside the public schema. The row already rendered schemaName beside the table name, and the call dropped it, so PostgreSQL's qualifier fell back to public.

Closes #772.

How

runMaintenance takes the container as a third argument, and the two call sites pass the schemaName their row already holds.

Engine	What the container does
PostgreSQL	qualifies the target, quoted whole; the name is never re-split
SQL Server	bracket-qualifies through escapeIdentifier
DuckDB	qualifies the target
MySQL	qualifies only when the container is not the connected database
ClickHouse	replaces the database half of the name
Oracle	owner-aware catalog reads, rebuildIndexes takes the owner
Couchbase	scopes the keyspace
SQLite, libSQL, MongoDB	ignore it, with a note saying why the operation cannot name one
Trino	refuses, since its maintenance has no container form

kill is untouched everywhere, because its "target" is a PID rather than a table.

Two of these were found while building rather than reported: Oracle's index rebuild answered ORA-01418 for a table name, and ClickHouse's parts listing read the wrong database, both because the schema never arrived.

Not a behaviour change for existing callers

The container is optional and the old readings stay when it is absent: a bare name still defaults to public, and schema.table is still quoted per-part.

Tests

Three provider tests pin the qualifier at the layer that builds the SQL:

• a container qualifies the target, and the target name is not re-split
• a container that itself contains a dot survives the qualifier (the old split-on-name reading could not survive this, which is the reason the parameter exists)
• without a container the old readings stay

Checking the container by splitting the name cannot work, since a schema may contain a dot, and that case is the one the third test above separates.

Verified by reverting the fix in postgres.ts and watching exactly the two container tests fail while the no-container one stays green, then mutating the qualifier to re-split the container on its dots and watching only the dot case fail.

Existing assertions in TablesTab.test.tsx and OperationsTab.test.tsx are updated to the three-argument call. 501 tests pass across the four touched files, tsc --noEmit is clean, and bun run lint reports 0 errors. The 13 pre-existing failures elsewhere in bun run test are identical on a clean base.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[cevheri]

Thanks for this. The PostgreSQL half is right: I ran all three buttons against a live PostgreSQL 17 with tables in app and in a dotted odd.schema, and both now succeed where they answered relation "public.Mytable" does not exist. It also merges cleanly with main and the full suite passes.

Three providers need a fix before I merge:

• MongoDB: assertContainerIsBound compares with config.database, but the row sends getDatabaseName(). On a connection-string connection every per-collection button now fails with bound to the database "". Compare with getDatabaseName().
• Couchbase: the Tables row carries the bucket in schemaName, not a scope, so Analyze builds travel.travel.travel.
• Oracle: with an owner, the index list comes from ALL_INDEXES, but ALTER INDEX "X" REBUILD is unqualified and rebuilds in the connected user's schema. Qualify it with the owner.

The #772 acceptance also asked for per-provider tests (non-default container, bare target, a name needing quoting) and the docs/providers/ maintenance sections, and only PostgreSQL has them so far. A test that the route and the hook pass container through is missing too. Those tests would have caught all three issues above.

[sloemo01]

All three fixed in afdb7919, with the tests the acceptance asked for.

MongoDB now compares getDatabaseName() instead of config.database. You were right about the reading, and the consequence was worse than a wrong sentence: a connection-string connection sets no config.database, so the check refused the database the provider is bound to and every per-collection button on that connection failed. Two arms pin it: the bound name is accepted, and a different one is still refused with the name in the sentence.

Couchbase places a bucket container at the default collection. That row is the only Tables row this provider has (getTableStats() reports the bucket under both schemaName and tableName), and it is the same placement every bucket-level catalog row already gets from resolveKeyspaceOf(): _default._default, not travel.travel.travel. Any other container is the scope, used as one rather than parsed back out of the display name, and the bare no-container reading is unchanged. Three arms cover the three readings plus one for quoting.

Oracle qualifies the rebuild. The list came from ALL_INDEXES with the owner bound, and ALTER INDEX "X" REBUILD was acting on the connected schema, which is not where the list came from. Each rebuild is now ALTER INDEX "<owner>"."<index>" REBUILD, and an arm asserts the unqualified spelling never appears.

Tests. The per-provider arms are in: MSSQL, MySQL, DuckDB and ClickHouse get container, bare and quoting arms each, and SQLite, libSQL and Trino get one pinning that the container is ignored with the reason. The route arm asserts the container reaches runMaintenance and that its absence arrives as undefined; the hook arm asserts the request body carries it.

Docs. Every touched provider section now states what the container means for that engine, in docs/providers/.

Verified on the touched files under bun 1.4.2 (the CI pin): 12 spec files, 1921 tests, all passing; typecheck, format, lint, security:check and readme:check clean; 0 uncovered lines across the three changed providers.

One note on scope: the earlier push of this branch was rebased onto current main (d44250e0) to keep it mergeable, so the head moved from d8567977 to afdb7919.

[sloemo01]

CI note on the current head. The only red leg on afdb7919 is Cross-platform Tests (windows-latest), and the failing test is the live-fetch arm of tests/unit/digitalocean-distribution.test.ts, where the real CLI fetches the DigitalOcean marketplace listing and counts the reads. This run came back with 0 after about 10.7 seconds; the other 13 tests in that file pass.

The file is untouched by this branch. The same test passes on other runs: the windows leg of run 36232944381 (2026-09-26 09:29) runs it green, and so does the leg on run 36239308227. Reading it as a fetch flake on the runner. I don't have re-run rights on this repo, so I'm noting it rather than bumping the head for a retry.

[cevheri]

Thanks, all three fixes check out. My probe against afdb7919 passes the MongoDB connection-string row, builds `travel`.`_default`.`_default` and rebuilds "HR"."ORDERS_PK". Merged with main, the suite passes at 100% coverage; the Windows red is the DigitalOcean live fetch.

One more round:

• ClickHouse: qualify() quotes the container with SQLBaseProvider.escapeIdentifier, which clickhouse/objects.ts:1073 records as unsafe there: a backslash escapes the closing quote. Container x\ with target .t FINAL SETTINGS optimize_throw_if_noop = 1 -- parses (clickhouse format 26.7.1) as OPTIMIZE TABLE `x".`.t FINAL SETTINGS optimize_throw_if_noop = 1. A dotted target could already do this. Please override escapeIdentifier for ClickHouse to escape the backslash too, as mssql.ts does, with a test for a trailing \.
• The audit event records only target, so app.orders and public.orders now log identically. Please record the container.
• A non-string container fails in the provider as identifier.replace is not a function. Please answer 400 at the route.
• docs/API_DOCS.md lists no container for this route.
• Couchbase answers Updated statistics for travel after touching only the default collection. Please name the keyspace.
• libsql and trino now stack two docblocks on runMaintenance; please merge them.

[sloemo01]

All six cleared in f71f052a, tests first (each arm was run against afdb7919 and failed before the fix landed), with the citation renumbering the edits forced.

1. ClickHouse escapeIdentifier. Overridden in clickhouse/index.ts the way mssql.ts overrides it: the backslash is doubled before the quote, which is the order literal() in objects.ts uses (doubling the quote first would leave the backslash looking like an escape of the doubled pair). Your request is now an arm: container x\ with target .t FINAL SETTINGS optimize_throw_if_noop = 1 -- emits

OPTIMIZE TABLE "x\\"".t FINAL SETTINGS optimize_throw_if_noop = 1 --" FINAL

and the arm asserts the naive spelling "x". never appears. Two more arms cover a bare target ending in a backslash and the escaper itself (escape("x\") is "x\\"). The provider doc records the override and its reason (§2.3 member table, [§8](#8-maintenance)).

2. Audit container. container?: string on AuditEvent and on the stdout AuditLogLine, spread only when set, the way reason and bucket are. The maintenance route passes the request's container through. Arm: two requests differing only in container produce two events that differ in container, and a whole-database request records none.

3. Route 400. Type-checked before any provider is opened:

{ "error": "\"container\" must be a string naming the target's container" }  with 400

An empty string is not malformed: it reads as a request that named no container, the same way an empty target reads as the whole-database form. Arms cover both.

4. docs/API_DOCS.md. container now has a field row on the route's request table, a mention in the request example, and the 400 it answers in the error section, with the wording moved to "a fifth 400" since the type check is a new one.

5. Couchbase. The analyze reply names the keyspace the statement addressed: Updated statistics for \travel`.`inventory`.`hotel`, not the bare target. Arm asserts the exact string after runMaintenance("analyze", "inventory.hotel")`; the provider doc's analyze row records it.

6. Stacked docblocks. libsql and trino each had two docblocks on runMaintenance; merged into one in each.

Verification.

• bun tests/run-tests.ts tests/integration/db/clickhouse-provider.test.ts tests/api/db/maintenance.test.ts tests/integration/db/couchbase-provider.test.ts tests/security/audit-redaction.test.ts -> 4 files passed, 404 tests pass (212 + 28 + 132 + 32).
• bun tests/run-tests.ts --jobs=4 (full suite) -> 599 files passed, 20762 tests: 20753 pass, 9 skip. The default 11-job run is flaky on this machine under load (load average 18 on 11 CPUs) and fails 15 files that pass alone; the same 15 fail identically at afdb7919 with the change stashed, so it is contention rather than this diff. 12 helm-chart files were not run: the chart's postgresql dependency is not built here.
• bun tests/run-tests.ts --coverage --merge-into=coverage/lcov.info --jobs=4 then bun run coverage:check -> check-coverage: OK - 63809/63809 lines (100.00%).
• bun run format, bun run lint (0 errors, 246 pre-existing warnings), bun run typecheck all clean.

One note beyond the six: my edits moved lines that five docblocks elsewhere cite by number (the route's 108-131 and 117, two audit.ts ranges, two API_DOCS.md lines). Renumbered in the same commit.

[sloemo01]

The head moved to 0ab20270, a punctuation-only follow-up to the docs lines from the reply above. All checks are green on it.

[cevheri]

Thanks, all six check out on 0ab20270. Against a live ClickHouse 26.7.1 the fixture's demo.bs_one\ now optimizes by all three spellings, and the review's container x\ is read as a database name and refused with UNKNOWN_DATABASE, where main fails on a syntax error. Through the running server a non-string container gets the 400 and the audit line carries container. I pushed two commits on top: a merge of main, since #1092 and #1148 changed the same provider docs, and a docs-only commit that cites by symbol where that merge moved a line, restates the reason in section 6.3 of clickhouse.md, and deletes D49, the backlog entry for this bug.