test(trino): cover a long-form IPv6 host against a short nextUri - #1093
Merged
cevheri merged 1 commit intoSep 24, 2026
Merged
Conversation
Member
|
hi @MohamedIdhries |
The existing IPv6 case cannot fail against a plain string compare: URL rewrites the link's host to [::1] before the check runs, so both sides are already the same string. Configure the long spelling and send the short one, next to the existing case. Refs libredb#1087
cevheri
force-pushed
the
fix/trino-nexturi-origin-verification
branch
from
September 24, 2026 20:09
7156396 to
55ae260
Compare
cevheri
approved these changes
Sep 24, 2026
Member
|
@MohamedIdhries I changed my mind on this one. #1090 landed the same check first, so I rebased your branch onto main and cut it down to the one piece main still lacked: your IPv6 test with the spellings swapped, long form configured and short form in the link. The old case passed even against a plain ===, this one does not. I force-pushed your branch, so reset your local copy before reusing it. Merged, thanks for the work. #976 is open if you want another one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…(fixes #1087)
Description
Type of Change
Related Issue
Closes #
Changes Made
Testing
Test Environment
Screenshots (if applicable)
Checklist
bun run test:coverageandbun run coverage:check)src/lib/db/providers/, I updated the matchingdocs/providers/documentation andtests/integration/db/tests in the same PR (provider triad)Additional Notes