support RisingWave jsonb schema queries - #1096
Open
Dharshini-RS03 wants to merge 3 commits into
Open
Dharshini-RS03 wants to merge 3 commits into
Dharshini-RS03 wants to merge 3 commits into
Conversation
cevheri
requested changes
Sep 23, 2026
cevheri
left a comment
Member
There was a problem hiding this comment.
Thanks for picking this up. I can't merge it yet: the fix is no longer in the diff. The merge cleanup commit (3b2e31c) put postgres.ts back to main and removed your test, so the PR now changes only the two docs files, and they describe a fallback the code doesn't have. CI passed because it ran main's code.
To finish it:
- Restore the provider change on top of current main. Besides the function names, the
NULL::jsonand'[]'::jsoncasts inpostgres.tsneed the same treatment, since RisingWave refuses those too. - Add a test to
tests/integration/db/postgres-provider.test.tsthat fails on main and coversdescribeObject()anddescribeObjects(). Please use the error RisingWave actually returns (recorded incompatibility.ts), not "type json does not exist". - Update the README row and the caveat in
compatibility.tsfrom your RisingWave run, and keep the parts that are still true (blank row counts and sizes, materialized views).
Small one: a tab replaced the "t" of "takes" in postgres.md. Please also update the PR description to match the final diff.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes RisingWave PostgreSQL object-browser schema reads by falling back from unsupported
jsonfunctions/types to the supportedjsonbequivalents.Type of Change
Related Issue
Closes #1075
Changes Made
json_agg()/json_build_object()andjsoncasts to theirjsonbequivalents.jsontojsonbfallback.Testing
Checklist
src/lib/db/providers/, I updated the matchingdocs/providers/documentation andtests/integration/db/tests in the same PR (provider triad)Additional Notes
The fix is implemented through the existing PostgreSQL provider fallback mechanism, so PostgreSQL connections continue using the original query when the JSON constructs are supported.