Skip to content

Fix for flushQueue db fetchAll - #1

Open
jchen-privco wants to merge 2 commits into
libreworks:masterfrom
privco:jchen/hotfix-spool-flush
Open

jchen-privco wants to merge 2 commits into
libreworks:masterfrom
privco:jchen/hotfix-spool-flush

Conversation

@jchen-privco

Copy link
Copy Markdown

While testing this in development of the email utility feature I discovered the original fork's flushQueue did not fetch the serialized emails from the database as intended. Using PDO::FETCH_COLUMN resulted in a unserialize failure.

@doublecompile

Copy link
Copy Markdown
Member

Hi, @jchen-privco. Thanks for the pull request! If you could please ensure the unit tests pass, I can accept this. Currently, all of the Travis CI builds fail.

@rahajidarmawan68-sketch

Copy link
Copy Markdown

@rahajidarmawan68-sketch

Copy link
Copy Markdown

Rahaji

@rahajidarmawan68-sketch rahajidarmawan68-sketch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants