Add deprecation notice of the Java-based implementation - #58
Merged
Merged
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Oct 13, 2025
|
|
||
| See the [VSS API contract] for details. | ||
|
|
||
| > [!CAUTION] |
Contributor
There was a problem hiding this comment.
nit: Should this be added beneath the Implementation heading?
Contributor
Author
There was a problem hiding this comment.
Thanks let me know how the diff below sounds
tankyleo
force-pushed
the
java-deprecation
branch
from
October 13, 2025 10:41
ba72076 to
b040e7e
Compare
tnull
approved these changes
Oct 13, 2025
tnull
left a comment
tnull
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but we should probably update the note soon again to say that the Rust version is ready-to-use (and maybe drop any mention of the Java version in the main README).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.