Skip to content

Fix release build step broken by the uv migration#72

Merged
markatto merged 1 commit into
mainfrom
mark/fix-release-workflow
Jul 22, 2026
Merged

Fix release build step broken by the uv migration#72
markatto merged 1 commit into
mainfrom
mark/fix-release-workflow

Conversation

@markatto

Copy link
Copy Markdown
Contributor

setup.py was deleted in #70 but the release workflow still runs uv run --frozen python setup.py sdist, so the next release would fail at the build step. The v2.10.2 release already failed to publish (its workflow run predates #70 and died in the old pipenv setup), which is why PyPI is still at 2.10.1. uv build produces the sdist and wheel from pyproject.toml directly, and gh-action-pypi-publish picks them up from dist/ as before.

Tested by running uv build in this branch: both artifacts build, and the wheel's lightspark_client.py compiles with no SyntaxWarning (the E614_REGEX escape fix from #47 is included, which 2.10.1 on PyPI predates).

setup.py was deleted in #70 but the release workflow still ran
"uv run --frozen python setup.py sdist", so the next release would
have failed at the build step (the v2.10.2 release already failed,
leaving PyPI at 2.10.1). uv build produces the sdist and wheel from
pyproject.toml directly.
@markatto
markatto marked this pull request as ready for review July 22, 2026 20:33
@markatto
markatto requested a review from mhrheaume July 22, 2026 20:33
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown

Greptile Summary

This PR repairs the release build after the move to pyproject.toml.

  • Replaces the deleted setup.py build command with uv build.
  • Produces a wheel and source archive in dist/ for the existing PyPI publish step.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The build output remains compatible with the existing publish step.

Important Files Changed

Filename Overview
.github/workflows/release.yaml Uses the pinned uv installation to create standard distributions in the directory consumed by the PyPI publishing action.

Reviews (1): Last reviewed commit: "Fix release build step broken by the uv ..." | Re-trigger Greptile

@markatto
markatto merged commit 26e1157 into main Jul 22, 2026
4 checks passed
@markatto
markatto deleted the mark/fix-release-workflow branch July 22, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants