Recover interrupted topic deletion on the 3.0 bridge - #596
Open
bringhurst wants to merge 2 commits into
Open
bringhurst wants to merge 2 commits into
bringhurst wants to merge 2 commits into
Conversation
This was referenced Sep 11, 2026
bringhurst
added this pull request to stack #581
September 11, 2026 23:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A 3.0 controller can stop during recursive topic deletion. The topic parent can retain reassignment fields after its leader/ISR znode is removed. The next controller then repeatedly fails reassignment startup. In the failed recovery run, producer-ID allocation timed out while the controller looped.
The new native startup regression also exposed a gap in #595: combined responses preserve deletion intent, but direct native StopReplica responses did not set the v4 deletion bit. The stricter callback therefore dropped genuine direct deletion acknowledgements.
Change
Under
li.protocol.bridge.topic.deletion.state.cleanup.enable, and only while deletion is enabled:Cleanup off retains the old behavior. Older wire responses remain unchanged. No deadline or record assertion is relaxed.
Evidence
expected true, got false) and passes after a real v4 serialization round trip. It covers cleanup off/on, deletion success/failure, and non-delete failure.testAlterReplicaLogDirscase. Actual RAT and archive build pass on Scala 2.12.Based on #595. Keep this in the 3.0 history; do not merge release lines.