[Golden Failed] Firewall & port forwarding: 7 new screen states have no baseline, 8 re-rendered — 1170 screens failing #1689

Daily Golden Verify on 2026-10-15 (branch dev-2.7.3) reports 1170 failing screens in Firewall and Port Forwarding. This is one suspected cause with two findings. Neither looks like a visual defect.

Suspected cause

• PR fix(firewall, port-forwarding): FWDEV#204's rules in the UI, and no silent saves (#1611, #1080) #1680: fix(firewall, port-forwarding): FWDEV#204's rules in the UI, and no silent saves ([Firewall] All eight toggles are inert on FL-WRT 2.0 — the rule-Description mapping matches 0 of 11 live rules #1611, Port Forwarding: The settings for "Port Range Forwarding" and "Port Range Triggering" are inconsistent with Linksys Now 1.x. #1080) (@AustinChangLinksys), merged 2026-10-14T05:21:01Z into dev-2.7.3. fix(firewall, port-forwarding): FWDEV#204's rules in the UI, and no silent saves (#1611, #1080) #1680
  It changes lib/page/firewall/views/usp_firewall_view.dart, lib/page/firewall/models/*, lib/page/port_forwarding/views/dialogs/port_range_forwarding_dialog.dart, port_triggering_dialog.dart, lib/page/port_forwarding/views/components/*, and the golden tests firewall/localizations/usp_firewall_view_test.dart and port_forwarding/localizations/usp_port_forwarding_detail_view_test.dart.

This is a suspected cause only, by file relevance: it is the only PR in the window (2026-10-10T20:15:08Z .. 2026-10-14T20:14:58Z) that changes both failing golden test files. PR #1682 (base fix/1611-fwdev204-gui-gaps, the branch of #1680) touches the same firewall files and is listed for context. PR #1664 changes lib/page/port_forwarding/views/usp_port_forwarding_detail_view.dart (ISP-limitation notice) but none of the failing dialog states. Both PRs merged after the last Generate Golden run (2026-10-13T00:04Z, golden-ci PR #39), so that pending baseline PR does not cover them.

Finding 1: missing baseline (546 screens)

Verdict: regression (baseline coverage gap) · confidence 🟢 High · broken_flag: false

7 new screen states have no golden PNG on the baseline branch: firewall-error, firewall-missing_rule, port_forwarding-dialog_overlap_and_lan_host_port_range, port_forwarding-dialog_overlap_port_triggering, port_forwarding-full_single_port, port_forwarding-full_port_range, port_forwarding-full_port_triggering. The PR description lists exactly these as new golden states.

• The report has no expected/actual/diff images for them (failureImages == null), and the goldenUrl returns HTTP 404 (checked firewall-error-phone480-el.png, port_forwarding-full_single_port-phone480-el.png).
• None of these states existed in the 2026-10-14 report.

No images were read for this finding because none exist.

Finding 2: re-rendered existing states (624 screens)

Verdict: intended (per PR description) · confidence 🟢 High · broken_flag: false

States: firewall-all_on, firewall-all_off, firewall-edit_dirty, port_forwarding-dialog_add_port_range, port_forwarding-dialog_add_port_triggering, port_forwarding-dialog_edit_port_range, port_forwarding-dialog_edit_port_triggering, port_forwarding-dialog_validation_port_range.

• Firewall: the current render adds a Filter Internet NAT redirection switch in Internet filters, which pushes the IPv6 Port Service card down. This matches the PR's + Filter Internet NAT redirection. Labels align with the other rows, nothing clipped.
• Port forwarding range dialog: the baseline has an Internal Port field; the current render does not, so the rest of the form moves up about 45 px and the dialog gets shorter. This matches the PR's - Internal Port field. In the current render all fields and the Cancel/Add buttons sit inside the dialog with padding; the overlap in the diff image is only the two layouts superimposed.

Images read: 5 (firewall-all_on|en|phone480 diff + actual, port_forwarding-dialog_add_port_range|en|phone480 diff + actual + baseline). All URLs returned 200 before reading. hasOverflow is false on every row; no new overflow today.

This finding is not auto-accepted into the baseline because Finding 1 is in the same run.

Failing screens

Pattern: every state fails in all 26 locales at every rendered width, en included — a content/layout change from one PR, not a translation or font issue.

Suggested next step

Run Generate Golden (mode=baseline, branch=dev-2.7.3) after reviewing the PR #1680 renders in the report. It refreshes golden-ci PR #39; merging it should clear both findings.

• Report: https://linksys.github.io/PrivacyGUI-golden-ci/verify/dev/2026-10-15/golden_verify_report.html
• Run: https://github.com/linksys/PrivacyGUI-golden-ci/actions/runs/38630443899