fix(at-spi): add accessible names for clipboard widgets - #280
deepin-bot[bot] merged 1 commit into
Conversation
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideAdds stable Qt object names across clipboard and related dock widgets so AT-SPI consumers and screen readers can identify controls, with YAML-based coverage expectations, licensing registration, and updated dock-plugin copyright ranges. Flow diagram for clipboard AT-SPI widget identificationflowchart LR
ClipboardWidgets[Clipboard and dock widgets] --> SetObjectName[setObjectName]
SetObjectName --> QtAccessibility[Qt accessibility bridge]
QtAccessibility --> ATSPI[AT-SPI consumers]
ATSPI --> ScreenReader[Screen reader]
ExpectedNames[expected_names.yaml] --> CoverageCheck[AST coverage check]
SetObjectName --> CoverageCheck
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
12aa63f to
cee9123
Compare
cee9123 to
491a95d
Compare
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
62c5ec2 to
a007372
Compare
Per DDE-198, setObjectName() is the AT-SPI positioning anchor (AccessibleId); setAccessibleName() retains screen-reader semantics only and is no longer a coverage gate. - Add setObjectName anchors: Listview/ClearButton/PlaceholderIcon (mainwindow), TipsCloseButton (tipswidget), ItemCloseButton (itemwidget), CopiedMessage (messagemanager), ClipboardDockIcon/QuickPanelWidget/ ClipboardQuickPanelIcon (dock-clipboard-plugin). - Make ItemWidget objectName unique per instance via a static counter so each clipboard item gets a distinct AT-SPI identifier instead of all sharing "ItemWidget". - Add tests/at/spi/expected_names.yaml fixture + REUSE.toml annotation. Log: 补全AT-SPI accessible name支持 Influence: 提升AT-SPI无障碍辅助覆盖率,剪贴板控件可被屏幕阅读器正确识别。
a007372 to
57a84bd
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
Summary
为 dde-clipboard 补全 AT-SPI accessibleName 支持,使剪贴板控件可被屏幕阅读器正确识别。
Changes
为以下控件添加
setObjectName和setAccessibleName调用:clipboardmodel.cpp—m_list(列表)mainwindow.cpp—m_listview(列表视图)mainwindow.cpp—m_placeholderIcon(占位图标)tipswidget.cpp—m_tipsCloseButton(关闭按钮)Coverage
Test
tests/at/spi/expected_names.yaml记录预期控件名称Log: 补全AT-SPI accessible name支持
Influence: 提升AT-SPI无障碍辅助覆盖率,剪贴板控件可被屏幕阅读器正确识别。
Summary by Sourcery
Improve AT-SPI accessibility coverage by assigning stable names to interactive clipboard widgets and documenting their expected identifiers.
New Features:
Bug Fixes:
Enhancements:
Tests:
Chores: