Conversation
- Add SearchIconSourceRole to expose iconSource (file://, qrc:/, resolved URLs) alongside the existing DecorationRole icon name, matching the icon binding pattern used by HomePage/SecondPage/DccEditorItem. - SearchBar.qml delegate now binds icon.source: model.iconSource so non-theme-icon entries render correctly instead of falling back to a broken or missing icon. - Extract iconObject() helper: use the search entry's own icon when set, fall back to the topmost ancestor icon otherwise. - Connect DccObject::iconChanged in DccManager and add refreshIcon() to SearchModel/SearchSourceModel so dynamically changed icons update search results via dataChanged without resetting filter/highlight. pms: BUG-372171
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fire-dtx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's GuideSearch results now select icons using the same own-icon/fallback-ancestor behavior as other pages, expose the resolved icon source to QML, and refresh affected delegates through targeted dataChanged signals when an object’s icon changes. Sequence diagram for refreshing search result iconssequenceDiagram
participant DccObject
participant DccManager
participant SearchModel
participant SearchSourceModel
participant SearchBar
DccObject->>DccManager: iconChanged()
DccManager->>SearchModel: refreshIcon(obj)
SearchModel->>SearchSourceModel: refreshIcon(obj)
SearchSourceModel-->>SearchSourceModel: iconObject()
SearchSourceModel-->>SearchBar: dataChanged(DecorationRole, SearchIconSourceRole)
SearchBar->>SearchBar: icon.source = model.iconSource
Flow diagram for selecting search result iconsflowchart LR
Entry[Search result entry] --> Own{Own icon set?}
Own -->|Yes| ObjectIcon[Entry icon]
Own -->|No| AncestorIcon[Topmost ancestor icon]
ObjectIcon --> Roles[DecorationRole and iconSource]
AncestorIcon --> Roles
Roles --> Delegate[SearchBar delegate]
Delegate --> Render[Render icon.name and icon.source]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
TAG Bot New tag: 6.1.106 |
|
TAG Bot New tag: 6.1.107 |
|
TAG Bot New tag: 6.1.109 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pms: BUG-372171
Summary by Sourcery
Fix search result icon rendering and update icons dynamically when DCC object icons change.
New Features:
Bug Fixes: