fix: clear history selection on backup return - #781
Closed
Johnson-zs wants to merge 1 commit into
Closed
Johnson-zs wants to merge 1 commit into
Johnson-zs wants to merge 1 commit into
Conversation
1. Root cause: ZipFileProcessResultWidget::backPage() only emitted changeWidget to switch page, missing clearWidget signal to reset selection states, leaving history selection after returning 2. Fix: emit TransferHelper::instance()->clearWidget() in backPage(), consistent with ResultDisplayWidget::nextPage() in transfer flow 3. Impact: backup result back now clears all selection controls, no change to page-switch logic, no effect on transfer flow Log: fix history selection not cleared after backup result back Influence: 1. Test backup complete then back to selection page, verify selections are cleared 2. Test transfer flow back to selection page, verify no regression 3. Test backup failed then back, verify selection cleared fix: 修复导出返回选择页时历史选择未清空 1. 根因:ZipFileProcessResultWidget::backPage() 仅发出 changeWidget 切换页面,缺少 clearWidget 信号清空选择状态,导致返回后历史选择残留 2. 方案:在 backPage() 中补充 emit clearWidget 信号,与传输流程 resultdisplay.cpp 现有范式保持一致 3. 影响:导出返回时清空各选择控件状态,不改变页面切换逻辑,不影响 传输流程 Log: 修复导出完成返回选择页时历史选择未清空的问题 Influence: 1. 测试导出完成后返回选择页,验证各选择项已清空 2. 测试传输流程返回选择页,验证无回归 3. 测试导出失败后返回,验证选择项已清空 PMS: BUG-262109
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Johnson-zs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideBackup result navigation now clears selection state by emitting a clearWidget signal when returning to the selection page, aligning backup behavior with the existing transfer flow pattern. Sequence diagram for clearing backup selections on returnsequenceDiagram
participant BackupResult as ZipFileProcessResultWidget
participant TransferHelper
participant ChoosePage as SelectionPage
BackupResult->>TransferHelper: changeWidget(PageName::choosewidget)
TransferHelper->>ChoosePage: Navigate to selection page
BackupResult->>TransferHelper: clearWidget()
TransferHelper->>ChoosePage: Clear selection controls
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: clear history selection on backup return
changeWidget to switch page, missing clearWidget signal to reset
selection states, leaving history selection after returning
consistent with ResultDisplayWidget::nextPage() in transfer flow
change to page-switch logic, no effect on transfer flow
Log: fix history selection not cleared after backup result back
Influence:
are cleared
fix: 修复导出返回选择页时历史选择未清空
切换页面,缺少 clearWidget 信号清空选择状态,导致返回后历史选择残留
resultdisplay.cpp 现有范式保持一致
传输流程
Log: 修复导出完成返回选择页时历史选择未清空的问题
Influence:
PMS: BUG-262109
Summary by Sourcery
Bug Fixes: